Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MODINVSTOR-1283 Modify endpoint for bulk instances upsert with publish events flag #1111

Closed
wants to merge 4 commits into from
Closed

MODINVSTOR-1283 Modify endpoint for bulk instances upsert with publish events flag #1111

wants to merge 4 commits into from

Conversation

psmagin
Copy link
Contributor

@psmagin psmagin commented Nov 5, 2024 •
edited
Loading

Purpose

Modify endpoint for bulk instances upsert with publish events flag

Approach

Add new field to bulk schema.

Changes Checklist

  • API Changes: Document any API paths, methods, request or response bodies changed, added, or removed.
  • Database Schema Changes: Indicate any database schema changes and their impact. Confirm that migration scripts were created.
  • Interface Version Changes: Indicate any changes to interface versions.
  • Interface Dependencies: Document added or removed dependencies.
  • Permissions: Document any changes to permissions.
  • Logging: Confirm that logging is appropriately handled.
  • Unit Testing: Confirm that changed classes were covered by unit tests.
  • Integration Testing: Confirm that changed logic was covered by integration tests.
  • Manual Testing: Confirm that changes were tested on local or dev environment.
  • NEWS: Confirm that the NEWS file is updated with relevant information about the changes made in this pull request.

Related Issues

https://folio-org.atlassian.net/browse/MODINVSTOR-1283

@psmagin psmagin marked this pull request as ready for review November 5, 2024 09:36
@psmagin psmagin requested a review from a team as a code owner November 5, 2024 09:36
@psmagin psmagin requested a review from RuslanLavrov November 5, 2024 09:39
@psmagin psmagin self-assigned this Nov 5, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@SvitlanaKovalova1
Copy link
Contributor

Please update NEWS.md
Should the API version "instance-storage-bulk" be updated?

@psmagin
Copy link
Contributor Author

psmagin commented Nov 5, 2024 •
edited
Loading

Please update NEWS.md Should the API version "instance-storage-bulk" be updated?

As the field is optional and has default value - we could omit API version change.

@psmagin psmagin closed this Nov 5, 2024
@psmagin psmagin reopened this Nov 5, 2024
@psmagin psmagin closed this Nov 5, 2024
@psmagin psmagin deleted the MODINVSTOR-1283 branch November 5, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SvitlanaKovalova1 SvitlanaKovalova1 SvitlanaKovalova1 approved these changes

@RuslanLavrov RuslanLavrov RuslanLavrov approved these changes

@viacheslavkol viacheslavkol Awaiting requested review from viacheslavkol viacheslavkol is a code owner automatically assigned from folio-org/spitfire-backend

@mukhiddin-yusuf mukhiddin-yusuf Awaiting requested review from mukhiddin-yusuf mukhiddin-yusuf is a code owner automatically assigned from folio-org/spitfire-backend

Assignees

@psmagin psmagin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@psmagin @SvitlanaKovalova1 @RuslanLavrov