fix(cn-browse): No highlighted match for call number with suffix when Call number type is specified #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Call number type is specified - modify comparison of shelfKey with anchor to ignore suffix if exist Closes: MSEARCH-558
ArtHov
requested review from
psmagin,
viacheslavkol,
hasanepam,
mukhiddin-yusuf and
andrei-razumnov
|
Kudos, SonarCloud Quality Gate passed! |
viacheslavkol
approved these changes
Sep 14, 2023
psmagin
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
No highlighted match for call number with suffix when Call number type is specified
Approach
modify comparison of shelfKey with anchor to ignore suffix if exist
Changes checklist
TODOS and Open Questions
Learning
Describe the research stage. Add links to blog posts, patterns, libraries or addons used to solve this problem.