Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(consortium): Add new facets for shared/local flag and tenantId #414

Merged
merged 4 commits into from
Sep 12, 2023

Conversation

psmagin
Copy link
Contributor

@psmagin psmagin commented Sep 8, 2023

Purpose

Add new facets for shared/local flag and tenantId

Approach

  • update elastic mappings
  • add subjects option for facet request

Changes checklist

  • API paths, methods, request or response bodies changed, added, or removed
  • Database schema changes
  • Interface versions changes
  • Interface dependencies added, or removed
  • Permissions changed, added, or removed
  • Check logging.

Learning

https://issues.folio.org/browse/MSEARCH-534

- update elastic mappings
- add `subjects` option for facet request

Closes: MSEARCH-534
@psmagin psmagin marked this pull request as ready for review September 8, 2023 14:48
@psmagin psmagin requested a review from a team as a code owner September 8, 2023 14:48
@psmagin psmagin self-assigned this Sep 8, 2023
@sonarcloud
Copy link

sonarcloud bot commented Sep 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

98.4% 98.4% Coverage
0.7% 0.7% Duplication

@psmagin psmagin merged commit 07ad34e into master Sep 12, 2023
3 checks passed
@psmagin psmagin deleted the MSEARCH-534 branch September 12, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants