Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSEARCH-635 Update module descriptor with environment variables #468

Merged
merged 5 commits into from
Nov 16, 2023

Conversation

GeloPakDev1
Copy link
Contributor

Purpose

Update module descriptor with environment variables

Approach

Go over the README file to add missing variables with description and default values into the ModuleDescriptor-template.json file

@GeloPakDev1 GeloPakDev1 marked this pull request as ready for review November 13, 2023 08:28
@GeloPakDev1 GeloPakDev1 requested a review from a team as a code owner November 13, 2023 08:28
README.md Outdated Show resolved Hide resolved
descriptors/ModuleDescriptor-template.json Outdated Show resolved Hide resolved
@GeloPakDev1 GeloPakDev1 requested a review from psmagin November 15, 2023 13:46
…ironment variables

- Update README with properties from application.yml
- Update ModuleDescriptor with missed environment variables from README.

Closes MSEARCH-635
@GeloPakDev1 GeloPakDev1 force-pushed the MSEARCH-635-Update-module-descriptor branch 2 times, most recently from 303ff88 to ffd7711 Compare November 15, 2023 16:39
Copy link

sonarcloud bot commented Nov 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@GeloPakDev1 GeloPakDev1 merged commit 3702bef into master Nov 16, 2023
6 checks passed
@psmagin psmagin deleted the MSEARCH-635-Update-module-descriptor branch February 21, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants