Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(browse-classifications): implement endpoint to browse by classifications #522

Merged
merged 5 commits into from
Feb 27, 2024

Conversation

psmagin
Copy link
Contributor

@psmagin psmagin commented Feb 24, 2024

Purpose

Implement endpoint to browse by classifications

Approach

  • Define API
  • Implement new endpoint logic
    -- Change logic of indexing to create shelving order for each algorithm
    -- Use browse config to find right field for browse
    -- Moved instance pre-processor earlier in a flow due to consortium complication logic

Changes Checklist

  • API Changes: Document any API paths, methods, request or response bodies changed, added, or removed.
  • Database Schema Changes: Indicate any database schema changes and their impact. Confirm that migration scripts were created.
  • Interface Version Changes: Indicate any changes to interface versions.
  • Interface Dependencies: Document added or removed dependencies.
  • Permissions: Document any changes to permissions.
  • Logging: Confirm that logging is appropriately handled.
  • Unit Testing: Confirm that changed classes were covered by unit tests.
  • Integration Testing: Confirm that changed logic was covered by integration tests.
  • Manual Testing: Confirm that changes were tested on local or dev environment.
  • NEWS: Confirm that the NEWS file is updated with relevant information about the changes made in this pull request.

Related Issues

https://folio-org.atlassian.net/browse/MSEARCH-665

@psmagin psmagin self-assigned this Feb 26, 2024
@psmagin psmagin changed the title fix(browse-classifications): implement endpoint to browse by classifi… fix(browse-classifications): implement endpoint to browse by classifications Feb 26, 2024
Signed-off-by: psmagin <[email protected]>
@psmagin psmagin marked this pull request as ready for review February 26, 2024 11:27
@psmagin psmagin requested a review from a team as a code owner February 26, 2024 11:27
@psmagin psmagin changed the title fix(browse-classifications): implement endpoint to browse by classifications feat(browse-classifications): implement endpoint to browse by classifications Feb 27, 2024
Copy link

sonarcloud bot commented Feb 27, 2024

@viacheslavkol viacheslavkol self-requested a review February 27, 2024 17:41
@psmagin psmagin merged commit 631fb52 into master Feb 27, 2024
6 checks passed
@psmagin psmagin deleted the MSEARCH-665 branch February 27, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants