Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSEARCH-781: Bibframe search functionality #596

Merged
merged 5 commits into from
Jun 5, 2024
Merged

MSEARCH-781: Bibframe search functionality #596

merged 5 commits into from
Jun 5, 2024

Conversation

pkjacob
Copy link
Contributor

@pkjacob pkjacob commented Jun 3, 2024

Purpose

Implement bibframe indexing in mod-search

Changes in this PR was merged to master branch last week. However, it got reverted later as it caused the failure in build-platform-complete-snapshot

Error:

fatal: [10.36.1.252]: FAILED! => {"changed": false, "connection": "close", "content": "POST request for mod-search-3.3.0-SNAPSHOT.537 /_/tenant failed with 400: {"errors":[{"message":"Unexpected value 'bibframe'","type":"IllegalArgumentException","code":"validation_error","parameters":[]}],"total_records":1}", "content_length": "222", "content_type": "text/plain", "elapsed": 152, "msg": "Status code was 400 and not [200]: HTTP Error 400: Bad Request", "redirected": false, "status": 400, "url": "http://10.36.1.252:9130/_/proxy/tenants/diku/install?deploy=true&tenantParameters=loadSample%3Dtrue%2CloadReference%3Dtrue%2CrunReindex%3Dtrue"}

Reason for failure:

reindexSupported was set as true in bibframe.json file. Due to this, a call to ReindexRequest.ResourceNameEnum.fromValue("bibframe") was made from SearchTenantService.createIndexesAndReindex(..) method. As ResourceNameEnum do not have a value bibframe, this line throwed exception IllegalArgumentException("Unexpected value 'bibframe'");

In this PR, I have removed the reindexSupported flag from bibframe.json file (commit).

Approach

Implement bibframe indexing in mod-search

Changes Checklist

  • API Changes: Document any API paths, methods, request or response bodies changed, added, or removed.
  • Database Schema Changes: Indicate any database schema changes and their impact. Confirm that migration scripts were created.
  • Interface Version Changes: Indicate any changes to interface versions.
  • Interface Dependencies: Document added or removed dependencies.
  • Permissions: Document any changes to permissions.
  • Logging: Confirm that logging is appropriately handled.
  • Unit Testing: Confirm that changed classes were covered by unit tests.
  • Integration Testing: Confirm that changed logic was covered by integration tests.
  • Manual Testing: Confirm that changes were tested on local or dev environment.
  • NEWS: Confirm that the NEWS file is updated with relevant information about the changes made in this pull request.

Related Issues

MSEARCH-781

@pkjacob pkjacob requested a review from a team as a code owner June 3, 2024 15:45
@pkjacob pkjacob changed the title Modld 369 MSEARCH-781: Bibframe search functionality Jun 3, 2024
Comment on lines 5 to 17
"fieldTypes": {
"suppress": {
"searchTypes": [ "facet", "filter" ],
"index": "bool",
"default": false
},
"visibleSuppress": {
"searchTypes": [ "facet", "filter" ],
"index": "bool",
"default": false,
"showInResponse": [ "search" ]
}
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't find where these defined types are used

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank You. Removed.
@psmagin

Copy link

sonarcloud bot commented Jun 5, 2024

@pkjacob pkjacob merged commit 26d5c80 into master Jun 5, 2024
8 checks passed
@psmagin psmagin deleted the MODLD-369 branch November 1, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants