-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MSEARCH-781: Bibframe search functionality #596
Conversation
"fieldTypes": { | ||
"suppress": { | ||
"searchTypes": [ "facet", "filter" ], | ||
"index": "bool", | ||
"default": false | ||
}, | ||
"visibleSuppress": { | ||
"searchTypes": [ "facet", "filter" ], | ||
"index": "bool", | ||
"default": false, | ||
"showInResponse": [ "search" ] | ||
} | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't find where these defined types are used
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank You. Removed.
@psmagin
Quality Gate passedIssues Measures |
Purpose
Implement bibframe indexing in mod-search
Changes in this PR was merged to master branch last week. However, it got reverted later as it caused the failure in build-platform-complete-snapshot
Error:
Reason for failure:
reindexSupported
was set astrue
in bibframe.json file. Due to this, a call toReindexRequest.ResourceNameEnum.fromValue("bibframe")
was made from SearchTenantService.createIndexesAndReindex(..) method. AsResourceNameEnum
do not have a valuebibframe
, this line throwed exceptionIllegalArgumentException("Unexpected value 'bibframe'");
In this PR, I have removed the reindexSupported flag from bibframe.json file (commit).
Approach
Implement bibframe indexing in mod-search
Changes Checklist
Related Issues
MSEARCH-781