Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSEARCH-782: Fix count for Shared facet in Contributor and Subjects browse #597

Merged
merged 7 commits into from
Jun 6, 2024

Conversation

mukhiddin-yusuf
Copy link
Contributor

@mukhiddin-yusuf mukhiddin-yusuf commented Jun 4, 2024

Purpose

Shared facet for Contributors and Subjects browse show incorrect values of shared/non-shared instances

Approach

Handle update event for instance sharing appropriately

Changes Checklist

  • API Changes: Document any API paths, methods, request or response bodies changed, added, or removed.
  • Database Schema Changes: Indicate any database schema changes and their impact. Confirm that migration scripts were created.
  • Interface Version Changes: Indicate any changes to interface versions.
  • Interface Dependencies: Document added or removed dependencies.
  • Permissions: Document any changes to permissions.
  • Logging: Confirm that logging is appropriately handled.
  • Unit Testing: Confirm that changed classes were covered by unit tests.
  • Integration Testing: Confirm that changed logic was covered by integration tests.
  • Manual Testing: Confirm that changes were tested on local or dev environment.
  • NEWS: Confirm that the NEWS file is updated with relevant information about the changes made in this pull request.

Related Issues

MSEARCH-782

Copy link

sonarcloud bot commented Jun 5, 2024

@mukhiddin-yusuf mukhiddin-yusuf merged commit c711e59 into master Jun 6, 2024
6 checks passed
@mukhiddin-yusuf mukhiddin-yusuf deleted the msearch-782 branch June 6, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants