Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MSEARCH-772]. Return Unified List of Inventory Libraries in a Consortium #613

Merged
merged 5 commits into from
Jun 28, 2024

Conversation

BKadirkhodjaev
Copy link
Contributor

Purpose

Return Unified List of Inventory Libraries in a Consortium (MSEARCH-772)

Approach

  • Add new path GET /search/consortium/libraries
  • Add filtering by tenant, sort by id, name and tenant id with pagination (limit & offset)
  • Add code generation files
  • Add unit and integration tests
  • Test manually using mod-search, mod-inventory-storage (master branch), Postman, Kafka-UI, Elasticsearch, Kibana (please follow the Jira ticket to see the test output).

Changes Checklist

  • API Changes: Document any API paths, methods, request or response bodies changed, added, or removed.
  • Database Schema Changes: Indicate any database schema changes and their impact. Confirm that migration scripts were created.
  • Interface Version Changes: Indicate any changes to interface versions.
  • Interface Dependencies: Document added or removed dependencies.
  • Permissions: Document any changes to permissions.
  • Logging: Confirm that logging is appropriately handled.
  • Unit Testing: Confirm that changed classes were covered by unit tests.
  • Integration Testing: Confirm that changed logic was covered by integration tests.
  • Manual Testing: Confirm that changes were tested on local or dev environment.
  • NEWS: Confirm that the NEWS file is updated with relevant information about the changes made in this pull request.

Related Issues

Return Unified List of Inventory Locations in a Consortium (MSEARCH-681)
Return Unified List of Inventory Campuses in a Consortium (MSEARCH-773)

@@ -3,7 +3,7 @@
"id": "83891666-dcb6-4cd7-ad3a-f4b305abfe21",
"name": "My campus 1",
"code": "MC1",
"campusId": "62cf76b7-cca5-4d33-9217-edf42ce1a848",
"institutionId": "62cf76b7-cca5-4d33-9217-edf42ce1a848",
Copy link
Contributor Author

@BKadirkhodjaev BKadirkhodjaev Jun 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed a typo missed in the previous PR, it is non-functional

Copy link

sonarcloud bot commented Jun 27, 2024

@BKadirkhodjaev BKadirkhodjaev merged commit 15db311 into master Jun 28, 2024
6 checks passed
@psmagin psmagin deleted the MSEARCH-772 branch November 1, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants