Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(search-instances): Index, search Index Instance place of publication field #614

Merged
merged 4 commits into from
Jul 2, 2024
Merged

feat(search-instances): Index, search Index Instance place of publication field #614

merged 4 commits into from
Jul 2, 2024

Conversation

viacheslavkol
Copy link
Contributor

@viacheslavkol viacheslavkol commented Jun 28, 2024 •
edited
Loading

Purpose

Index, search Index Instance place of publication field

Approach

  • Update dto
  • Update index mappings

Changes Checklist

  • API Changes: Document any API paths, methods, request or response bodies changed, added, or removed.
  • Database Schema Changes: Indicate any database schema changes and their impact. Confirm that migration scripts were created.
  • Interface Version Changes: Indicate any changes to interface versions.
  • Interface Dependencies: Document added or removed dependencies.
  • Permissions: Document any changes to permissions.
  • Logging: Confirm that logging is appropriately handled.
  • Unit Testing: Confirm that changed classes were covered by unit tests.
  • Integration Testing: Confirm that changed logic was covered by integration tests.
  • Manual Testing: Confirm that changes were tested on local or dev environment.
  • NEWS: Confirm that the NEWS file is updated with relevant information about the changes made in this pull request.

Related Issues

MSEARCH-755

@viacheslavkol
feat(search-instances): Index, search Index Instance place of publica…
898bb58 
…tion field

- Update dto
- Update index mappings

Implements: MSEARCH-755
@viacheslavkol viacheslavkol self-assigned this Jun 28, 2024
@viacheslavkol viacheslavkol marked this pull request as ready for review June 28, 2024 16:43
@viacheslavkol viacheslavkol requested a review from a team as a code owner June 28, 2024 16:43
@viacheslavkol viacheslavkol requested a review from psmagin July 1, 2024 13:24
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@viacheslavkol viacheslavkol merged commit f67eed0 into master Jul 2, 2024
6 checks passed
@viacheslavkol viacheslavkol deleted the MSEARCH-755 branch July 2, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viacheslavpoliakov viacheslavpoliakov viacheslavpoliakov approved these changes

@mukhiddin-yusuf mukhiddin-yusuf mukhiddin-yusuf approved these changes

@psmagin psmagin psmagin approved these changes

Assignees

@viacheslavkol viacheslavkol

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@viacheslavkol @psmagin @mukhiddin-yusuf @viacheslavpoliakov