Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cn-browse): modify usage of shelving order for call-number browse #675

Merged
merged 3 commits into from
Oct 15, 2024

Conversation

psmagin
Copy link
Contributor

@psmagin psmagin commented Oct 11, 2024

Purpose

Modify usage of shelving order for call-number browse

Approach

  • Calculate shelving order on mod-search side
  • Remove calculating order for local call-number types as the option is not used on UI

Changes Checklist

  • API Changes: Document any API paths, methods, request or response bodies changed, added, or removed.
  • Database Schema Changes: Indicate any database schema changes and their impact. Confirm that migration scripts were created.
  • Interface Version Changes: Indicate any changes to interface versions.
  • Interface Dependencies: Document added or removed dependencies.
  • Permissions: Document any changes to permissions.
  • Logging: Confirm that logging is appropriately handled.
  • Unit Testing: Confirm that changed classes were covered by unit tests.
  • Integration Testing: Confirm that changed logic was covered by integration tests.
  • Manual Testing: Confirm that changes were tested on local or dev environment.
  • NEWS: Confirm that the NEWS file is updated with relevant information about the changes made in this pull request.

Related Issues

https://folio-org.atlassian.net/browse/MSEARCH-831

@psmagin psmagin changed the title feat(cn-browse): modify usage of shelving order feat(cn-browse): modify usage of shelving order for call-number browse Oct 11, 2024
@psmagin psmagin marked this pull request as ready for review October 11, 2024 08:34
@psmagin psmagin requested a review from a team as a code owner October 11, 2024 08:34
@psmagin psmagin self-assigned this Oct 11, 2024
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@psmagin psmagin merged commit 9a01db4 into master Oct 15, 2024
7 of 8 checks passed
@psmagin psmagin deleted the MSEARCH-831 branch October 15, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants