Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(reindex): Extend instance-records reindex endpoint with passing index settings #681

Merged
merged 7 commits into from
Oct 21, 2024

Conversation

viacheslavkol
Copy link
Contributor

@viacheslavkol viacheslavkol commented Oct 16, 2024

Purpose

Extend instance-records reindex endpoint with passing index settings

Approach

  • Extend full/upload reindex endpoints with index settings
  • Recreate indices on publishing merge ranges instead of doing this on upload start in order to use index settings
  • Add instance reindexing to tenant service
  • Remove instance record type from old reindex endpoint

Changes Checklist

  • API Changes: Document any API paths, methods, request or response bodies changed, added, or removed.
  • Database Schema Changes: Indicate any database schema changes and their impact. Confirm that migration scripts were created.
  • Interface Version Changes: Indicate any changes to interface versions.
  • Interface Dependencies: Document added or removed dependencies.
  • Permissions: Document any changes to permissions.
  • Logging: Confirm that logging is appropriately handled.
  • Unit Testing: Confirm that changed classes were covered by unit tests.
  • Integration Testing: Confirm that changed logic was covered by integration tests.
  • Manual Testing: Confirm that changes were tested on local or dev environment.
  • NEWS: Confirm that the NEWS file is updated with relevant information about the changes made in this pull request.

Related Issues

MSEARCH-853

Learning and Resources (if applicable)

During full reindex, index recreation is not longer part of upload stage. Indices get recreated after publishing records ranges in order to pass index settings.
During upload reindex, index recreation logic stays intact

…index settings

- Extend full/upload reindex endpoints with index settings
- Recreate indices on publishing merge ranges instead of doing this on upload start in order to use index settings
- Add instance reindexing to tenant service
- Remove instance record type from old reindex endpoint

Implements: MSEARCH-853
@viacheslavkol viacheslavkol self-assigned this Oct 16, 2024
@viacheslavkol
Copy link
Contributor Author

Verified on rancher environment. Full/upload endpoints accept and act on passed index settings

@viacheslavkol viacheslavkol marked this pull request as ready for review October 17, 2024 17:09
@viacheslavkol viacheslavkol requested a review from a team as a code owner October 17, 2024 17:09
@viacheslavkol viacheslavkol requested a review from psmagin October 18, 2024 12:18
Copy link

sonarcloud bot commented Oct 21, 2024

@viacheslavkol viacheslavkol merged commit 26e91b8 into master Oct 21, 2024
6 checks passed
@viacheslavkol viacheslavkol deleted the MSEARCH-853 branch October 21, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants