Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cn-browse): Implement call number browse config #703

Merged
merged 3 commits into from
Nov 29, 2024
Merged

feat(cn-browse): Implement call number browse config #703

merged 3 commits into from
Nov 29, 2024

Conversation

viacheslavkol
Copy link
Contributor

@viacheslavkol viacheslavkol commented Nov 28, 2024 •
edited
Loading

Purpose

Implement call number browse config

Approach

  • Populate default call number browse configs in db
  • Update browse config endpoints
  • Implement call number type events consumer

Changes Checklist

  • API Changes: Document any API paths, methods, request or response bodies changed, added, or removed.
  • Database Schema Changes: Indicate any database schema changes and their impact. Confirm that migration scripts were created.
  • Interface Version Changes: Indicate any changes to interface versions.
  • Interface Dependencies: Document added or removed dependencies.
  • Permissions: Document any changes to permissions.
  • Logging: Confirm that logging is appropriately handled.
  • Unit Testing: Confirm that changed classes were covered by unit tests.
  • Integration Testing: Confirm that changed logic was covered by integration tests.
  • Manual Testing: Confirm that changes were tested on local or dev environment.
  • NEWS: Confirm that the NEWS file is updated with relevant information about the changes made in this pull request.

Related Issues

MSEARCH-863

@viacheslavkol
feat(cn-browse): Implement call number browse config
129c116 
- Populate default call number browse configs in db
- Update browse config endpoints
- Implement call number type events consumer

Implements: MSEARCH-863
@viacheslavkol viacheslavkol self-assigned this Nov 28, 2024
@viacheslavkol viacheslavkol changed the base branch from feature/call-number-browse-v3 to feature/call-number-browse-v2 November 29, 2024 09:15
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@viacheslavkol viacheslavkol marked this pull request as ready for review November 29, 2024 11:06
@viacheslavkol viacheslavkol requested a review from a team as a code owner November 29, 2024 11:06
@viacheslavkol viacheslavkol requested review from psmagin, mukhiddin-yusuf and SvitlanaKovalova1 and removed request for a team November 29, 2024 11:06
@viacheslavkol viacheslavkol merged commit 21cecb8 into feature/call-number-browse-v2 Nov 29, 2024
6 checks passed
@viacheslavkol viacheslavkol deleted the MSEARCH-863 branch November 29, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SvitlanaKovalova1 SvitlanaKovalova1 SvitlanaKovalova1 approved these changes

@psmagin psmagin psmagin approved these changes

@mukhiddin-yusuf mukhiddin-yusuf Awaiting requested review from mukhiddin-yusuf mukhiddin-yusuf is a code owner automatically assigned from folio-org/spitfire-backend

Assignees

@viacheslavkol viacheslavkol

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@viacheslavkol @psmagin @SvitlanaKovalova1