Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cn-browse): Implement Indexing and Re-indexing Mechanisms for Call-Numbers #707

Merged
merged 1 commit into from
Dec 5, 2024
Merged

feat(cn-browse): Implement Indexing and Re-indexing Mechanisms for Call-Numbers #707

merged 1 commit into from
Dec 5, 2024

Conversation

psmagin
Copy link
Contributor

@psmagin psmagin commented Dec 3, 2024 •
edited
Loading

Purpose

Implement Indexing and Re-indexing Mechanisms for Call-Numbers

Approach

  • define index mapping
  • adjust extractors and repository to save and fetch call-numbers

Changes Checklist

  • API Changes: Document any API paths, methods, request or response bodies changed, added, or removed.
  • Database Schema Changes: Indicate any database schema changes and their impact. Confirm that migration scripts were created.
  • Interface Version Changes: Indicate any changes to interface versions.
  • Interface Dependencies: Document added or removed dependencies.
  • Permissions: Document any changes to permissions.
  • Logging: Confirm that logging is appropriately handled.
  • Unit Testing: Confirm that changed classes were covered by unit tests.
  • Integration Testing: Confirm that changed logic was covered by integration tests.
  • Manual Testing: Confirm that changes were tested on local or dev environment.
  • NEWS: Confirm that the NEWS file is updated with relevant information about the changes made in this pull request.

Related Issues

https://folio-org.atlassian.net/browse/MSEARCH-864

@psmagin psmagin marked this pull request as ready for review December 4, 2024 09:30
@psmagin psmagin requested a review from a team as a code owner December 4, 2024 09:30
@psmagin psmagin requested review from viacheslavkol, mukhiddin-yusuf and SvitlanaKovalova1 and removed request for a team December 4, 2024 09:30
@psmagin psmagin self-assigned this Dec 4, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 4, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@psmagin psmagin merged commit 24bae72 into feature/call-number-browse-v2 Dec 5, 2024
8 checks passed
@psmagin psmagin deleted the MSEARCH-864 branch December 5, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viacheslavkol viacheslavkol viacheslavkol approved these changes

@mukhiddin-yusuf mukhiddin-yusuf Awaiting requested review from mukhiddin-yusuf mukhiddin-yusuf is a code owner automatically assigned from folio-org/spitfire-backend

@SvitlanaKovalova1 SvitlanaKovalova1 Awaiting requested review from SvitlanaKovalova1 SvitlanaKovalova1 is a code owner automatically assigned from folio-org/spitfire-backend

Assignees

@psmagin psmagin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@psmagin @viacheslavkol