Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cn-browse): Implement browsing endpoint for Call Numbers #712

Merged
merged 1 commit into from
Dec 12, 2024
Merged

feat(cn-browse): Implement browsing endpoint for Call Numbers #712

merged 1 commit into from
Dec 12, 2024

Conversation

psmagin
Copy link
Contributor

@psmagin psmagin commented Dec 11, 2024 •
edited
Loading

Purpose

Implement browsing endpoint for Call Numbers

Approach

  • Define browse endpoint in API-files
  • Adjust facet endpoint to work with call-numbers resource
  • Implement new browse service (use common logic from classification browse service)

Changes Checklist

  • API Changes: Document any API paths, methods, request or response bodies changed, added, or removed.
  • Database Schema Changes: Indicate any database schema changes and their impact. Confirm that migration scripts were created.
  • Interface Version Changes: Indicate any changes to interface versions.
  • Interface Dependencies: Document added or removed dependencies.
  • Permissions: Document any changes to permissions.
  • Logging: Confirm that logging is appropriately handled.
  • Unit Testing: Confirm that changed classes were covered by unit tests.
  • Integration Testing: Confirm that changed logic was covered by integration tests.
  • Manual Testing: Confirm that changes were tested on local or dev environment.
  • NEWS: Confirm that the NEWS file is updated with relevant information about the changes made in this pull request.

Related Issues

https://folio-org.atlassian.net/browse/MSEARCH-865

@psmagin psmagin self-assigned this Dec 12, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 12, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@psmagin psmagin marked this pull request as ready for review December 12, 2024 09:11
@psmagin psmagin requested a review from a team as a code owner December 12, 2024 09:11
@psmagin psmagin requested review from viacheslavkol, mukhiddin-yusuf and SvitlanaKovalova1 and removed request for a team December 12, 2024 09:11
@psmagin psmagin merged commit b1bb502 into feature/call-number-browse-v2 Dec 12, 2024
7 of 8 checks passed
@psmagin psmagin deleted the MSEARCH-865 branch December 12, 2024 12:02
mukhiddin-yusuf
mukhiddin-yusuf reviewed Dec 12, 2024
View reviewed changes
src/main/resources/swagger.api/parameters/instance-call-number-browse-cql-query.yaml
summary: Search for all classification numbers before "DT571.F84"
browseAroundWithFilters:
value: (number >= "DT571.F84" or number < "DT571.F84") and instances.shared==false
summary: Search for local classification numbers before and after "DT571.F84"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe in examples we want to mention call-number instead of classification numbers

src/main/resources/swagger.api/paths/browse-call-numbers/browse-instance-call-numbers.yaml
application/json:
examples:
browseResult:
$ref: '../../examples/result/browseClassificationNumberResult.yaml'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

browseClassificationNumberResult.yaml maybe example call-number result

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mukhiddin-yusuf mukhiddin-yusuf mukhiddin-yusuf left review comments

@viacheslavkol viacheslavkol viacheslavkol approved these changes

@SvitlanaKovalova1 SvitlanaKovalova1 Awaiting requested review from SvitlanaKovalova1 SvitlanaKovalova1 is a code owner automatically assigned from folio-org/spitfire-backend

Assignees

@psmagin psmagin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@psmagin @viacheslavkol @mukhiddin-yusuf