refactor: Separate out chronology and enumeration #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial domain model work seperating out TemplateMetadataRules into chronology and enumeration arrays, removing parent classes assigning these based on refdata WIP
Additionally seperated out enumeration and chronology templateMetadataRuleFormats, is building but ALOT more testing needs to be done WIP
Added initial migrations for handling domain class changes and renaming of new fields WIP
Updated views to new domain models
Within the templateConfig, updated chronology/enumeration to be chronologyRules/enumerationRules
Updated methods within services and domain models to match the new domain models Are we finally in a posistion that this works? I hope so
|
At this point i'm tempted to update naming conventions and package structure, however I would prefer for this PR to remain as legible as possible |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work is to change how the module handles the chronology/enumeration template metadata rules attached to a rulesets template config. In various places throughout both the frontend and backend modules we do work to either seperate or combine these two which could be avoided and overall simplified if they were treated as individual arrays
MODSER-42