Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UISACQCOMP-232: Move reusable helper function to support version history functionality #833

Merged
merged 4 commits into from
Nov 21, 2024

Conversation

alisher-epam
Copy link
Contributor

Purpose

UISACQCOMP-232: Move reusable helper function to support version history functionality.

  • Move reusable getAcqUnitsByIds helper function from ui-orders
  • Move reusable getVersionMetadata helper function from ui-invoices

Approach

Pre-Merge Checklist

Before merging this PR, please go through the following list and take appropriate actions.

  • I've added appropriate record to the CHANGELOG.md
  • Does this PR meet or exceed the expected quality standards?
    • Code coverage on new code is 80% or greater
    • Duplications on new code is 3% or less
    • There are no major code smells or security issues
  • Does this introduce breaking changes?
    • If any API-related changes - okapi interfaces and permissions are reviewed/changed correspondingly
    • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

  • What other modules will these changes impact?
  • Do JIRAs exist to update the impacted modules?
    • If not, please create them
    • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
    • Do they have all they appropriate links to blocked/related issues?
  • Are the JIRAs under active development?
    • If not, contact the project's PO and make sure they're aware of the urgency.
  • Do PRs exist for these changes?
    • If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

@alisher-epam alisher-epam self-assigned this Nov 21, 2024
@alisher-epam alisher-epam requested review from usavkov-epam and a team November 21, 2024 06:13
Copy link

github-actions bot commented Nov 21, 2024

Jest Unit Test Statistics

    1 files  ±0  223 suites  +1   4m 5s ⏱️ -1s
593 tests +3  591 ✔️ +3  2 💤 ±0  0 ±0 
596 runs  +3  594 ✔️ +3  2 💤 ±0  0 ±0 

Results for commit b18b98a. ± Comparison against base commit e8132c3.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 21, 2024

BigTest Unit Test Statistics

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ±0 

Results for commit b18b98a. ± Comparison against base commit e8132c3.

♻️ This comment has been updated with latest results.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to keep it here https://github.com/folio-org/stripes-acq-components/tree/master/lib/utils/api near another api functions and with the same name convention and implementation approach

Copy link

sonarcloud bot commented Nov 21, 2024

@alisher-epam alisher-epam merged commit 30b44ad into master Nov 21, 2024
6 checks passed
@alisher-epam alisher-epam deleted the UISACQCOMP-232 branch November 21, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants