Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STCOR-594 read ky timeout from stripes-config value #1347

Merged
merged 1 commit into from
Oct 9, 2023
Merged

STCOR-594 read ky timeout from stripes-config value #1347

merged 1 commit into from
Oct 9, 2023

Conversation

vashjs
Copy link
Contributor

@vashjs vashjs commented Oct 6, 2023

Based on the STCOR-594, timout inside useOkapiKy should be configurable

@github-actions
Copy link

github-actions bot commented Oct 6, 2023 •
edited
Loading

Jest Unit Test Statistics

74 tests  ±0   74 ✔️ ±0   13s ⏱️ ±0s
12 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 5eac62e. ± Comparison against base commit 4997ab8.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 6, 2023 •
edited
Loading

BigTest Unit Test Statistics

    1 files  ±0      1 suites  ±0   10s ⏱️ ±0s
271 tests ±0  266 ✔️ ±0  5 💤 ±0  0 ❌ ±0 
274 runs  ±0  269 ✔️ ±0  5 💤 ±0  0 ❌ ±0 

Results for commit 5eac62e. ± Comparison against base commit 4997ab8.

This pull request removes 5 and adds 3 tests. Note that renamed tests count towards both. 
      equal to check email label in english translation
      equal to check email precautions label in english translation
      equal to sent email precautions label in english translation
Chrome_117_0_0_0_(Linux_x86_64).Forgot username form test ‑ Forgot username form test check email status page tests should have the header with an appropriate text content
Chrome_117_0_0_0_(Linux_x86_64).Forgot username form test ‑ Forgot username form test check email status page tests should have the paragraph with an appropriate text content

Chrome_117_0_0_0_(Linux_x86_64).Forgot username form test ‑ Forgot username form test check email status page tests should have the header with an appropriate text content
      equal to check email label in english translation
Chrome_117_0_0_0_(Linux_x86_64).Forgot username form test ‑ Forgot username form test check email status page tests should have the paragraph with an appropriate text content
      equal to check email precautions label in english translation
Chrome_117_0_0_0_(Linux_x86_64).Forgot username form test ‑ Forgot username form test check email status page tests should have the paragraph with an appropriate text content
      equal to sent email precautions label in english translation

♻️ This comment has been updated with latest results.

@sonarcloud
Copy link

sonarcloud bot commented Oct 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@vashjs vashjs requested a review from zburke October 6, 2023 10:05
zburke
zburke approved these changes Oct 6, 2023
View reviewed changes
Copy link
Member

@zburke zburke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for finally picking this up! It's nice to chip away at some of these little changes that can have a big impact.

@vashjs vashjs merged commit f02c954 into master Oct 9, 2023
5 checks passed
@vashjs vashjs deleted the STCOR-594 branch October 9, 2023 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zburke zburke zburke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vashjs @zburke