STCOR-907 cautiously evaluate localforage data #1561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Be thorough when evaluating data from localforage to determine whether a session exists by checking for `user.id`, `tenant`, and `isAuthenticated` values rather than accepting the existence of a (possibly empty, or mostly empty) object as proof. Without this check, a sparsely-populated value may be passed to `validateUser()`, causing it to throw when evaluating `user.id`, and misleadingly dispatching a server-down message. It is likely that a rogue RTR process is responsible for writing this garbled/sparse session data. We need to research that and resolve that problem too, but at least we have a handle on this from the other end. Refs STCOR-907
JohnC-80
approved these changes
Nov 20, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Be thorough when evaluating data from localforage to determine whether a session exists by checking for
user.id,tenant, andisAuthenticatedvalues rather than accepting the existence of a (possibly empty, or mostly empty) object as proof of life. Without these more thorough checks, a sparsely-populated value may be passed tovalidateUser(), causing it to throw when evaluatinguser.id, and misleadingly dispatching a server-down message.It is likely that a rogue RTR process is responsible for writing this garbled/sparse session data. We need to research that and resolve that problem too, but at least we have a handle on this from the other end.
Refs STCOR-907