Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STSMACOM-787 Export new advancedSearchQueryToRows helper to be used in Inventory app to reduce code duplication #1409

Merged
merged 3 commits into from
Oct 31, 2023
Merged

STSMACOM-787 Export new advancedSearchQueryToRows helper to be used in Inventory app to reduce code duplication #1409

merged 3 commits into from
Oct 31, 2023

Conversation

BogdanDenis
Copy link
Contributor

@BogdanDenis BogdanDenis commented Oct 30, 2023 •
edited
Loading

Description

Export new advancedSearchQueryToRows helper to be used in Inventory app to reduce code duplication

Screenshots

chrome_soEjTfa0jk.mp4

Issues

STSMACOM-787

@BogdanDenis
STSMACOM-787 Export new advancedSearchQueryToRows helper to be used…
94d0711 
… in Inventory app to reduce code duplication
@github-actions
Copy link

github-actions bot commented Oct 30, 2023 •
edited
Loading

Jest Unit Test Statistics

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit 3f059de. ± Comparison against base commit 2641cd5.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 30, 2023 •
edited
Loading

BigTest Unit Test Statistics

    1 files  ±0      1 suites  ±0   15s ⏱️ -1s
441 tests ±0  405 ✔️ ±0  36 💤 ±0  0 ❌ ±0 
443 runs  ±0  407 ✔️ ±0  36 💤 ±0  0 ❌ ±0 

Results for commit 3f059de. ± Comparison against base commit 2641cd5.

♻️ This comment has been updated with latest results.

@BogdanDenis BogdanDenis requested review from Dmytro-Melnyshyn and a team October 30, 2023 15:30
@BogdanDenis BogdanDenis marked this pull request as ready for review October 30, 2023 15:30
@BogdanDenis BogdanDenis mentioned this pull request Oct 30, 2023
Merged
@sonarqubecloud SonarQubeCloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 0 Code Smells

83.3% 83.3% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@BogdanDenis BogdanDenis merged commit dbb6c43 into master Oct 31, 2023
4 of 5 checks passed
@BogdanDenis BogdanDenis deleted the STSMACOM-787 branch October 31, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vashjs vashjs vashjs approved these changes

@Dmytro-Melnyshyn Dmytro-Melnyshyn Dmytro-Melnyshyn approved these changes

@UladzislauKutarkin UladzislauKutarkin UladzislauKutarkin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BogdanDenis @UladzislauKutarkin @Dmytro-Melnyshyn @vashjs