STSMACOM-748: Show the username in the 'last updated' accordion in the Note editing pane. #1412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e Note editing pane.
BogdanDenis
requested changes
Nov 7, 2023
| } = responseMetadata; | ||
|
|
||
| const lastUpdatedBy = createdByUserId === updatedByUserId |
There was a problem hiding this comment.
I think we can just use updatedByUsername in both cases.
If ids are equal - we're passing createdBy, which is the same as updatedByUsername
If they are not - we're passing updatedByUsername
So we can just remove the conditional
|
Kudos, SonarCloud Quality Gate passed! |
BogdanDenis
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Show the
usernamein thelast updatedaccordion in the Note editing pane.Issues
STSMACOM-748
Screenshots