Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STSMACOM-796 Show successful toast notifications for Create and Edit actions in <ControlledVocab> #1426

Merged
merged 3 commits into from
Jan 10, 2024
Merged

STSMACOM-796 Show successful toast notifications for Create and Edit actions in <ControlledVocab> #1426

merged 3 commits into from
Jan 10, 2024

Conversation

BogdanDenis
Copy link
Contributor

Description

Show successful toast notifications for Create and Edit actions in <ControlledVocab>

Screenshots

chrome_AVGpcgzWCn.mp4
chrome_aJUQ430Cti.mp4

Issues

STSMACOM-796

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2024 •
edited
Loading

Jest Unit Test Statistics

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit 70b46e0. ± Comparison against base commit 6ebd303.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2024 •
edited
Loading

BigTest Unit Test Statistics

    1 files  ±0      1 suites  ±0   13s ⏱️ -1s
448 tests +3  412 ✔️ +3  36 💤 ±0  0 ❌ ±0 
450 runs  +3  414 ✔️ +3  36 💤 ±0  0 ❌ ±0 

Results for commit 70b46e0. ± Comparison against base commit 6ebd303.

♻️ This comment has been updated with latest results.

@BogdanDenis BogdanDenis requested review from Dmytro-Melnyshyn and a team January 8, 2024 15:56
@BogdanDenis BogdanDenis mentioned this pull request Jan 8, 2024
Merged
artem-blazhko
artem-blazhko reviewed Jan 8, 2024
View reviewed changes
Copy link
Contributor

@artem-blazhko artem-blazhko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you get rid of eslint errors?

@artem-blazhko artem-blazhko requested a review from a team January 8, 2024 18:56
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
81.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@BogdanDenis BogdanDenis merged commit a877258 into master Jan 10, 2024
6 checks passed
@BogdanDenis BogdanDenis deleted the STSMACOM-796 branch January 10, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dmytro-Melnyshyn Dmytro-Melnyshyn Dmytro-Melnyshyn approved these changes

@artem-blazhko artem-blazhko artem-blazhko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BogdanDenis @artem-blazhko @Dmytro-Melnyshyn