Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SearchAndSort prop documentation updates #1428

Merged
merged 18 commits into from
Jan 9, 2024
Merged

SearchAndSort prop documentation updates #1428

merged 18 commits into from
Jan 9, 2024

Conversation

ncovercash
Copy link
Member

@ncovercash ncovercash commented Jan 8, 2024 •
edited
Loading

  • adds missing props to README:
    • actionMenu
    • autofocusSearchField
    • browseOnly
    • pagingType/pagingCanGoNext/pagingCanGoPrevious/pageAmount
    • paneTitleRef
    • customPaneSub
    • detailProps
    • getCellClass
    • hidePageIndices
    • initiallySelectedRecord
    • nonInteractiveHeaders
    • onCloseNewRecord
    • onComponentWillUnmount
    • onResetAll
    • resultCountMessageKey
    • resultsFormatter
    • resultsOnNeedMore
    • showSingleResult
    • validateSearchOnSubmit
  • documents notLoadedMessage as node, not string (overrides a <FormattedMessage>, so we know nodes are OK)

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2024 •
edited
Loading

Jest Unit Test Statistics

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit fa38300. ± Comparison against base commit d3dc0f4.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2024 •
edited
Loading

BigTest Unit Test Statistics

    1 files  ±0      1 suites  ±0   12s ⏱️ ±0s
445 tests ±0  409 ✔️ ±0  36 💤 ±0  0 ❌ ±0 
447 runs  ±0  411 ✔️ ±0  36 💤 ±0  0 ❌ ±0 

Results for commit fa38300. ± Comparison against base commit d3dc0f4.

♻️ This comment has been updated with latest results.

@ncovercash ncovercash marked this pull request as ready for review January 8, 2024 21:37
@ncovercash ncovercash requested review from zburke and JohnC-80 January 8, 2024 21:37
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 8, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@ncovercash ncovercash mentioned this pull request Jan 8, 2024
Merged
@ncovercash ncovercash merged commit 6ebd303 into master Jan 9, 2024
6 checks passed
@zburke zburke deleted the searchandsort-update-docs branch October 25, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweaver-ebsco mweaver-ebsco mweaver-ebsco approved these changes

@zburke zburke zburke approved these changes

@JohnC-80 JohnC-80 Awaiting requested review from JohnC-80

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ncovercash @zburke @mweaver-ebsco