Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UICIRC-983: Add hour to the time frequency for reminder fees #1074

Merged
merged 2 commits into from
Sep 22, 2023
Merged

UICIRC-983: Add hour to the time frequency for reminder fees #1074

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fdcb2f4
UICIRC-983: Add hour to the time frequency for reminder fees
mkuklis Sep 22, 2023
a72f394
Merge branch 'master' into UICIRC-983
mkuklis Sep 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@
* *BREAKING* bump `react-intl` to `v6.4.4`. Refs UICIRC-977.
* Add informational message for Holds to New Request Policy page. Refs UICIRC-981.
* Restore previously deleted Jest/RTL tests that were failing. Refs UICIRC-971.
* Add "hour" to the time frequency for reminder fees. Fixes UICIRC-983.
* Freeze the first five selection menus for reminder fees. Refs UICIRC-982.

## [8.0.1](https://github.com/folio-org/ui-circulation/tree/v8.0.1) (2023-03-07)
Expand Down
5 changes: 5 additions & 0 deletions src/constants.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,6 +378,7 @@ export const closingTypesMap = {
};

export const timeUnitsMap = {
HOUR: 'hour',
DAY: 'day',
WEEK: 'week',
};
Expand Down Expand Up @@ -409,6 +410,10 @@ export const closedLoansRules = {
};

export const timeUnits = [
{
value: timeUnitsMap.HOUR,
label: 'ui-circulation.settings.finePolicy.reminderFees.timeUnit.hours',
},
{
value: timeUnitsMap.DAY,
label: 'ui-circulation.settings.finePolicy.reminderFees.timeUnit.days',
Expand Down
1 change: 1 addition & 0 deletions translations/ui-circulation/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -440,6 +440,7 @@
"settings.finePolicy.reminderFees.selectNoticeMethod": "Select notice method",
"settings.finePolicy.reminderFees.selectNoticeTemplate": "Select notice template",
"settings.finePolicy.reminderFees.selectBlockTemplate": "Select block template",
"settings.finePolicy.reminderFees.timeUnit.hours": "Hour(s)",
"settings.finePolicy.reminderFees.timeUnit.days": "Day(s)",
"settings.finePolicy.reminderFees.timeUnit.weeks": "Week(s)",
"settings.finePolicy.reminderFees.noticeMethods.email": "Email",
Expand Down
Loading