Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UICIRC-992: Also support feesfines interface version 19.0 #1080

Merged
merged 2 commits into from
Oct 18, 2023
Merged

UICIRC-992: Also support feesfines interface version 19.0 #1080

merged 2 commits into from
Oct 18, 2023

Conversation

Dmitriy-Litvinenko
Copy link
Contributor

@Dmitriy-Litvinenko Dmitriy-Litvinenko commented Oct 11, 2023 •
edited
Loading

Purpose

Also support feesfines interface version 19.0

Approach

Changes was in endpoint /accounts that do not used in current module
This is part of Quesnelia (R1 2024) release
Should be merged after merging https://issues.folio.org/browse/MODFEE-337

Refs

https://issues.folio.org/browse/UICIRC-992

@Dmitriy-Litvinenko Dmitriy-Litvinenko requested review from artem-blazhko and a team October 11, 2023 12:08
@github-actions
Copy link

github-actions bot commented Oct 11, 2023 •
edited
Loading

BigTest Unit Test Statistics

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit 94c330f. ± Comparison against base commit 581fcd7.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 11, 2023 •
edited
Loading

Jest Unit Test Statistics

       1 files  ±0     165 suites  ±0   1m 40s ⏱️ -10s
1 814 tests ±0  1 814 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
1 851 runs  ±0  1 851 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 94c330f. ± Comparison against base commit 581fcd7.

♻️ This comment has been updated with latest results.

zburke
zburke requested changes Oct 11, 2023
View reviewed changes
Copy link
Member

@zburke zburke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new interface support looks fine, but assuming this is supposed to land if v9, you need to fix the CHANGELOG entry. Or if this is intended for v10 then you need to bump the version in package.json too.

@Dmitriy-Litvinenko Dmitriy-Litvinenko requested review from zburke and a team October 12, 2023 08:33
@Dmitriy-Litvinenko
Copy link
Contributor Author

@zburke Could you please review (package.json updated)? Current pull request will be merged after release previous release.

zburke
zburke approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@zburke zburke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌 Adding a new version of an existing interface is fine in a minor version. The thing that's tricky is removing supported versions, e.g. changing from

"feesfines": "16.2 17.0 18.0"

to

"feesfines": "16.3 17.0 18.0"

is a breaking change because you're removing support for something you used to handle.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Dmitriy-Litvinenko Dmitriy-Litvinenko merged commit 4f6daa0 into master Oct 18, 2023
5 checks passed
@Dmitriy-Litvinenko Dmitriy-Litvinenko deleted the UICIRC-992 branch October 18, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artem-blazhko artem-blazhko artem-blazhko approved these changes

@zburke zburke zburke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Dmitriy-Litvinenko @zburke @artem-blazhko