UICIRC-1118: Implement feature toggle for ECS and not ECS envs #1177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dmitriy-Litvinenko
force-pushed
the
UICIRC-1118
branch
3 times, most recently
from
ec90f98 to
e6b5e12
Compare
Dmitriy-Litvinenko
requested review from
artem-blazhko and
IvanKryzhanovskyi
Dmitriy-Litvinenko
force-pushed
the
UICIRC-1118
branch
from
e6b5e12 to
b18e7b1
Compare
artem-blazhko
approved these changes
Nov 16, 2024
IvanKryzhanovskyi
approved these changes
Nov 18, 2024
Dmitriy-Litvinenko
force-pushed
the
UICIRC-1118
branch
from
b18e7b1 to
d25e50e
Compare
Dmitriy-Litvinenko
force-pushed
the
UICIRC-1118
branch
from
d25e50e to
29d5755
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Use feature flag
enableEcsRequestsfrom stripes configuration file for handling functionality for ECS and not ECS related envs.Approach
It was decided that we should use separated components with old and new implementation instead of having a lot of
if...elsestatements in the code.This approach let us split functionality by feature flags much faster.
Refs
https://folio-org.atlassian.net/browse/UICIRC-1118
Notes