Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UICIRC-1128: Added missing translations #1183

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Conversation

Dmitriy-Litvinenko
Copy link
Contributor

@Dmitriy-Litvinenko Dmitriy-Litvinenko commented Dec 3, 2024

Purpose

Added missing translations

Refs

https://folio-org.atlassian.net/browse/UICIRC-1128

Copy link

github-actions bot commented Dec 3, 2024

Jest Unit Test Statistics

       1 files  ±0     186 suites  ±0   1m 17s ⏱️ -1s
1 982 tests ±0  1 982 ✔️ ±0  0 💤 ±0  0 ±0 
2 022 runs  ±0  2 022 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 09f9f51. ± Comparison against base commit b37527f.

♻️ This comment has been updated with latest results.

Copy link
Member

@zburke zburke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the PR description to change what is changing, i.e. what the state of the code will be after this change is complete. If you're fixing a bug, don't describe the bug. After the PR merges, the bug will be gone, so a description of a problem that used to be there isn't important.

This PR adds several new translation keys but does not update any code to point to them. After this PR merges, nothing will change. Am I missing something? Were these keys missing? If so, state that in the description, e.g. instead of "incorrect name for TLR" say "Provide missing translations".

@Dmitriy-Litvinenko Dmitriy-Litvinenko changed the title UICIRC-1128: Incorrect name for Title level request setting UICIRC-1128: Added missing translations Dec 3, 2024
@Dmitriy-Litvinenko
Copy link
Contributor Author

Dmitriy-Litvinenko commented Dec 3, 2024

Use the PR description to change what is changing, i.e. what the state of the code will be after this change is complete. If you're fixing a bug, don't describe the bug. After the PR merges, the bug will be gone, so a description of a problem that used to be there isn't important.

This PR adds several new translation keys but does not update any code to point to them. After this PR merges, nothing will change. Am I missing something? Were these keys missing? If so, state that in the description, e.g. instead of "incorrect name for TLR" say "Provide missing translations".

Thank you rename to "Added missing translations"
Could you please re-review?

Copy link

sonarqubecloud bot commented Dec 3, 2024

@Dmitriy-Litvinenko Dmitriy-Litvinenko merged commit ff7a54f into master Dec 3, 2024
5 checks passed
@Dmitriy-Litvinenko Dmitriy-Litvinenko deleted the UICIRC-1128 branch December 3, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants