Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIEH-1446: Add target='_blank' to the New button of agreements accordion. #1754

Merged
merged 1 commit into from
Dec 24, 2024

Conversation

Dmytro-Melnyshyn
Copy link
Contributor

@Dmytro-Melnyshyn Dmytro-Melnyshyn commented Dec 23, 2024

Purpose

Open a new tab by clicking the New button of agreements accordion.

Approach

Add target='_blank' to the New button of agreements accordion.

Isssue

UIEH-1446

TODOS and Open Questions

Learning

Screenshots

2024-12-23_14h29_28.mp4

@Dmytro-Melnyshyn Dmytro-Melnyshyn requested a review from a team December 23, 2024 12:34
Copy link

Jest Unit Test Results

    1 files  ±0    193 suites  ±0   5m 2s ⏱️ +8s
1 095 tests ±0  1 092 ✅ ±0  3 💤 ±0  0 ❌ ±0 
1 103 runs  ±0  1 100 ✅ ±0  3 💤 ±0  0 ❌ ±0 

Results for commit 9048643. ± Comparison against base commit 3c28682.

This pull request removes 1 and adds 1 tests. Note that renamed tests count towards both.
Given AgreementsAccordion after click on "New" button should redirect to create page of agreements app ‑ Given AgreementsAccordion after click on "New" button should redirect to create page of agreements app
Given AgreementsAccordion should have correct props in the "New" button ‑ Given AgreementsAccordion should have correct props in the "New" button

@Dmytro-Melnyshyn Dmytro-Melnyshyn merged commit 6f9d7e8 into master Dec 24, 2024
16 checks passed
@Dmytro-Melnyshyn Dmytro-Melnyshyn deleted the UIEH-1446 branch December 24, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants