Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIIN-3143: Set the previously used offset by executing resultOffset.replace when changing the segment. #2680

Merged
merged 3 commits into from
Dec 2, 2024

Conversation

Dmytro-Melnyshyn
Copy link
Contributor

Purpose

Retain pagination after switching segments.

Approach

Set the previously used offset by executing resultOffset.replace when changing the segment.

Refs

UIIN-3143

Screenshots

2024-11-28_16h05_47.mp4

@Dmytro-Melnyshyn Dmytro-Melnyshyn requested review from BogdanDenis and a team November 28, 2024 14:17
Copy link

github-actions bot commented Nov 28, 2024

Jest Unit Test Statistics

       1 files  ±0     253 suites  ±0   14m 26s ⏱️ - 1m 0s
1 015 tests +1  1 013 ✔️ +1  2 💤 ±0  0 ±0 
1 022 runs  +1  1 020 ✔️ +1  2 💤 ±0  0 ±0 

Results for commit febb649. ± Comparison against base commit cc8fe10.

♻️ This comment has been updated with latest results.

Copy link

sonarcloud bot commented Dec 2, 2024

@Dmytro-Melnyshyn Dmytro-Melnyshyn merged commit d9f70e3 into master Dec 2, 2024
5 checks passed
@Dmytro-Melnyshyn Dmytro-Melnyshyn deleted the UIIN-3143 branch December 2, 2024 17:34
mariia-aloshyna pushed a commit that referenced this pull request Dec 4, 2024
…replace' when changing the segment. (#2680)

(cherry picked from commit d9f70e3)
mariia-aloshyna added a commit that referenced this pull request Dec 4, 2024
* UIIN-3127: Display informative error message when editing same instance, holdings, item in two tabs (#2672)

(cherry picked from commit c0f1176)

* UIIN-3147 User can edit Source consortium "Holdings sources" in member tenant but not in Consortia manager (#2681)

(cherry picked from commit 034df62)

* UIIN-3143: Set the previously used offset by executing 'resultOffset.replace' when changing the segment. (#2680)

(cherry picked from commit d9f70e3)

* Release v12.0.5

---------

Co-authored-by: Oleksandr Hladchenko <[email protected]>
Co-authored-by: Mikita Siadykh <[email protected]>
Co-authored-by: Dmytro-Melnyshyn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants