refactoring after code review

folio-org · Oct 25, 2024 · f4f9dea · f4f9dea
1 parent 1b94e00
commit f4f9dea
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/src/common/hooks/useFetchSearchData.ts b/src/common/hooks/useFetchSearchData.ts
@@ -1,5 +1,5 @@
 import { useCallback } from 'react';
-import { useSetRecoilState, useRecoilState, SetterOrUpdater } from 'recoil';
+import { useSetRecoilState, useRecoilState, SetterOrUpdater, useResetRecoilState } from 'recoil';
 import { getByIdentifier } from '@common/api/search.api';
 import { SearchIdentifiers, SearchSegment } from '@common/constants/search.constants';
 import { SearchableIndexQuerySelector } from '@common/constants/complexLookup.constants';
@@ -10,7 +10,7 @@ import { UserNotificationFactory } from '@common/services/userNotification';
 import state from '@state';
 import { useSearchContext } from './useSearchContext';
 
-export const useFetchSearhData = () => {
+export const useFetchSearchData = () => {
   const {
     endpointUrl,
     searchFilter,
@@ -27,8 +27,10 @@ export const useFetchSearhData = () => {
   const setIsLoading = useSetRecoilState(state.loadingState.isLoading);
   const setMessage = useSetRecoilState(state.search.message);
   const [data, setData] = useRecoilState(state.search.data);
+  const resetData = useResetRecoilState(state.search.data);
   const setPageMetadata = useSetRecoilState(state.search.pageMetadata);
   const setStatusMessages = useSetRecoilState(state.status.commonMessages);
+  const resetStatusMessage = useResetRecoilState(state.status.commonMessages);
 
   const validateAndNormalizeQuery = useCallback(
     (type: SearchIdentifiers, query: string) => {
@@ -143,10 +145,10 @@ export const useFetchSearhData = () => {
       selectedSegment,
       baseQuerySelector = SearchableIndexQuerySelector.Query,
     }: FetchDataParams) => {
-      setMessage('');
+      resetStatusMessage();
       const selectedNavigationSegment = selectedSegment ?? navigationSegment?.value;
 
-      data && setData(null);
+      data && resetData();
 
       const updatedQuery = validateAndNormalizeQuery(searchBy, query);
       if (!updatedQuery) return;

diff --git a/src/common/hooks/useSearch.ts b/src/common/hooks/useSearch.ts
@@ -8,7 +8,7 @@ import { generateSearchParamsState } from '@common/helpers/search.helper';
 import { usePagination } from '@common/hooks/usePagination';
 import state from '@state';
 import { useSearchContext } from './useSearchContext';
-import { useFetchSearhData } from './useFetchSearchData';
+import { useFetchSearchData } from './useFetchSearchData';
 
 export const useSearch = () => {
   const {
@@ -32,7 +32,7 @@ export const useSearch = () => {
   const [facetsBySegments, setFacetsBySegments] = useRecoilState(state.search.facetsBySegments);
   const clearFacetsBySegments = useResetRecoilState(state.search.facetsBySegments);
 
-  const { fetchData } = useFetchSearhData();
+  const { fetchData } = useFetchSearchData();
   const {
     getCurrentPageNumber,
     setCurrentPageNumber,