UIOR-1038 Some shortcut keys do not work in the "Orders" app #1424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r in form and prevents to close accordion
|
Kudos, SonarCloud Quality Gate passed! |
ryandberger
approved these changes
Nov 21, 2022
vashjs
approved these changes
Nov 22, 2022
usavkov-epam
added a commit
that referenced
this pull request
Nov 25, 2022
* UIOR-1038 fix 'new order' and 'duplicate order' shortcuts * UIOR-1038 fix toggle handling of 'ongoing order information' accordion * UIOR-1038 fix accordion toggle handling in POLineForm * UIOR-1038 async validation of field-arrays always set Promise as error in form and prevents to close accordion * UIOR-1038 update changelog * add unit test for 'new' shortcut
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
https://issues.folio.org/browse/UIOR-1038
Approach
POLineFormandOrderTenplatesEditorforms omit async field-arrays errors, that prevents toggle accordions - there is an issue with async validation ofFieldArrayitself. Async validation ofFundDistributionFieldsFinalfield-array delegates error state to hidden field.Pre-Merge Checklist
Before merging this PR, please go through the following list and take appropriate actions.
If there are breaking changes, please STOP and consider the following:
Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.
While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.