fix code smells

src/Organizations/OrganizationForm/OrganizationBankingInfoForm/BankingInformationField/BankingInformationField.js

@@ -46,7 +46,7 @@ export const BankingInformationField = ({
 
       return acc;
     }, []);
-  }, [addressCategoryIdsSet, categories]);
+  }, [addressCategoryIdsSet, categories, initCategoryId]);
 
   return (
     <Card headerStart={cardHeader}>
@@ -115,8 +115,8 @@ BankingInformationField.propTypes = {
     label: PropTypes.string,
     value: PropTypes.string,
   })).isRequired,
-  categoriesOptions: PropTypes.arrayOf(PropTypes.shape({
-    label: PropTypes.string,
+  categories: PropTypes.arrayOf(PropTypes.shape({
+    id: PropTypes.string,
     value: PropTypes.string,
   })).isRequired,
   fields: PropTypes.object.isRequired,

src/Organizations/OrganizationForm/OrganizationBankingInfoForm/BankingInformationFieldArray/BankingInformationFieldArray.js

@@ -1,3 +1,4 @@
+import PropTypes from 'prop-types';
 import { useEffect } from 'react';
 import { useForm } from 'react-final-form';
 
@@ -40,3 +41,7 @@ export const BankingInformationFieldArray = (props) => {
 
   return <RepeatableFieldWithValidation {...props} />;
 };
+
+BankingInformationFieldArray.propTypes = {
+  fields: PropTypes.object.isRequired,
+};

src/Organizations/OrganizationForm/OrganizationBankingInfoForm/BankingInformationFieldArray/index.js

@@ -1 +1 @@
-export { BankingInformationFieldArray } from './BankingInformationFieldArray'
+export { BankingInformationFieldArray } from './BankingInformationFieldArray';

src/Organizations/OrganizationForm/getAddressCategoryIdsSet.js

@@ -6,4 +6,4 @@ export const getAddressCategoryIdsSet = memoize((addresses = []) => {
 
     return acc;
   }, new Set());
-})
+});

src/Organizations/useBankingInformationManager.js

@@ -43,7 +43,10 @@ export const useBankingInformationManager = () => {
     } = getArrayItemsChanges(initBankingInformation, bankingInformation);
 
     return Promise.all([
-      executeSequentially(createBankingInformation, created.map((item) => ({ organizationId: organization.id, ...item }))),
+      executeSequentially(createBankingInformation, created.map((item) => ({
+        organizationId: organization.id,
+        ...item,
+      }))),
       executeParallel(updateBankingInformation, updated),
       executeParallel(deleteBankingInformation, deleted),
     ]).catch(() => {
@@ -52,7 +55,13 @@ export const useBankingInformationManager = () => {
         messageId: 'ui-organizations.bankingInformation.save.error',
       });
     });
-  }, [showCallout]);
+  }, [
+    createBankingInformation,
+    deleteBankingInformation,
+    isBankingInformationEnabled,
+    showCallout,
+    updateBankingInformation,
+  ]);
 
   return {
     manageBankingInformation,

src/Utils/CategoryDropdown/CategoryDropdown.js

@@ -48,7 +48,7 @@ function CategoryDropdown({
     change(fieldName, value);
 
     if (onChangeProp) onChangeProp(value);
-  }, [onChangeProp]);
+  }, [change, fieldName, onChangeProp]);
 
   return (
     <FieldMultiSelectionFinal