UIORGS-388 Update perms hierarchy for repeatable fields usage

folio-org · Nov 22, 2023 · ad2e98b · ad2e98b
1 parent 93da350
commit ad2e98b
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 13 deletions.
diff --git a/package.json b/package.json
@@ -159,29 +159,29 @@
         ]
       },
       {
-        "permissionName": "ui-organizations.banking-information.create",
-        "displayName": "Organizations: View and create banking information",
+        "permissionName": "ui-organizations.banking-information.edit",
+        "displayName": "Organizations: View and edit banking information",
         "visible": true,
         "subPermissions": [
           "ui-organizations.banking-information.view",
-          "organizations.banking-information.item.post"
+          "organizations.banking-information.item.put"
         ]
       },
       {
-        "permissionName": "ui-organizations.banking-information.edit",
-        "displayName": "Organizations: View, create and edit banking information",
+        "permissionName": "ui-organizations.banking-information.create",
+        "displayName": "Organizations: View, edit and create banking information",
         "visible": true,
         "subPermissions": [
-          "ui-organizations.banking-information.create",
-          "organizations.banking-information.item.put"
+          "ui-organizations.banking-information.edit",
+          "organizations.banking-information.item.post"
         ]
       },
       {
         "permissionName": "ui-organizations.banking-information.delete",
-        "displayName": "Organizations: View, create, edit and delete banking information",
+        "displayName": "Organizations: View, edit, create and delete banking information",
         "visible": true,
         "subPermissions": [
-          "ui-organizations.banking-information.edit",
+          "ui-organizations.banking-information.create",
           "organizations.banking-information.item.delete"
         ]
       },

diff --git a/...Organizations/OrganizationForm/OrganizationBankingInfoForm/OrganizationBankingInfoForm.js b/...Organizations/OrganizationForm/OrganizationBankingInfoForm/OrganizationBankingInfoForm.js
@@ -57,6 +57,7 @@ export const OrganizationBankingInfoForm = () => {
     <FieldArray
       addLabel={<FormattedMessage id="ui-organizations.button.bankingInformation.add" />}
       component={BankingInformationFieldArray}
+      canAdd={stripes.hasPerm('ui-organizations.banking-information.create')}
       canRemove={stripes.hasPerm('ui-organizations.banking-information.delete')}
       id="bankingInformation"
       name={BANKING_INFORMATION_FIELD_NAME}

diff --git a/src/Organizations/OrganizationForm/OrganizationForm.js b/src/Organizations/OrganizationForm/OrganizationForm.js
@@ -224,7 +224,7 @@ const OrganizationForm = ({
                         </Accordion>
 
                         {isBankingInformationEnabled && (
-                          <IfPermission perm="ui-organizations.banking-information.create">
+                          <IfPermission perm="ui-organizations.banking-information.edit">
                             <Accordion
                               id={ORGANIZATION_SECTIONS.bankingInformationSection}
                               label={ORGANIZATION_SECTION_LABELS[ORGANIZATION_SECTIONS.bankingInformationSection]}

diff --git a/translations/ui-organizations/en.json b/translations/ui-organizations/en.json
@@ -480,9 +480,9 @@
   "permission.acqUnits.assign": "Organizations: Assign acquisition units to new organization",
   "permission.acqUnits.manage": "Organizations: Manage acquisition units",
   "permission.banking-information.view": "Organizations: View banking information",
-  "permission.banking-information.create": "Organizations: View and create banking information",
-  "permission.banking-information.edit": "Organizations: View, create and edit banking information",
-  "permission.banking-information.delete": "Organizations: View, create, edit and delete banking information",
+  "permission.banking-information.edit": "Organizations: View and edit banking information",
+  "permission.banking-information.create": "Organizations: View, edit and create banking information",
+  "permission.banking-information.delete": "Organizations: View, edit, create and delete banking information",
   "permission.settings.view": "Settings (Organizations): View settings",
   "permission.settings": "Settings (Organizations): Can view and edit settings"
 }