Skip to content

Commit

Permalink
UIORGS-445 clean up ui-organizations permissions (#648)
Browse files Browse the repository at this point in the history
  • Loading branch information
@NikitaSedyx
NikitaSedyx authored Oct 16, 2024
1 parent aee28f0 commit d2fe45f
Show file tree
Hide file tree
Showing 18 changed files with 4,527 additions and 74,067 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/build-npm-release.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ jobs:
comment_title: Jest Unit Test Statistics

- name: Publish Jest coverage report
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v3
if: always()
with:
name: jest-coverage-report
Expand All @@ -170,15 +170,15 @@ jobs:
comment_title: BigTest Unit Test Statistics

- name: Publish BigTest coverage report
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v3
if: always()
with:
name: bigtest-coverage-report
path: ${{ env.BIGTEST_COVERAGE_REPORT_DIR }}
retention-days: 30

- name: Publish yarn.lock
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v3
if: failure()
with:
name: yarn.lock
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/build-npm.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ jobs:
comment_title: Jest Unit Test Statistics

- name: Publish Jest coverage report
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v3
if: always()
with:
name: jest-coverage-report
Expand All @@ -113,15 +113,15 @@ jobs:
comment_title: BigTest Unit Test Statistics

- name: Publish BigTest coverage report
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v3
if: always()
with:
name: bigtest-coverage-report
path: ${{ env.BIGTEST_COVERAGE_REPORT_DIR }}
retention-days: 30

- name: Publish yarn.lock
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v3
if: failure()
with:
name: yarn.lock
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
* UX Consistency: HTML Page Title display when the third pane (detail record) displays. Refs UIORGS-423.
* Settings > Organizations > Banking information is not properly fenced off by permissions. Refs UIORGS-436.
* Use Save & close button label stripes-component translation key - all UI modules. Refs UIORGS-425.
* Clean up ui-organizations permissions. Refs UIORGS-445.

## [5.1.1](https://github.com/folio-org/ui-organizations/tree/v5.1.1) (2024-04-18)
[Full Changelog](https://github.com/folio-org/ui-organizations/compare/v5.1.0...v5.1.1)
Expand Down
5 changes: 3 additions & 2 deletions package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,9 @@
]
},
{
"permissionName": "ui-organizations.third-party-services",
"permissionName": "ui-organizations.third-party-services.execute",
"displayName": "Organizations: Permissions required to call services apart from mod-organizations-storage",
"replaces": ["ui-organizations.third-party-services"],
"visible": false,
"subPermissions": [
"acquisitions-units.memberships.collection.get",
Expand Down Expand Up @@ -102,7 +103,7 @@
"organizations-storage.settings.collection.get",
"organizations-storage.urls.collection.get",
"organizations-storage.urls.item.get",
"ui-organizations.third-party-services"
"ui-organizations.third-party-services.execute"
]
},
{
Expand Down
209 changes: 112 additions & 97 deletions ...ration/OrganizationIntegrationForm/__snapshots__/OrganizationIntegrationForm.test.js.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -108,41 +108,45 @@ exports[`OrganizationIntegrationForm should render correct form structure 1`] =
id="integrationInfo"
>
<div
class="headerWrapper"
style="width: 100%; display: flex;"
tabindex="-1"
>
<div
class="header default"
class="headerWrapper"
>
<h3
class="headline size-medium margin-none font-weight-bold block"
data-test-headline="true"
<div
class="header default"
>
<button
aria-controls="accordion1"
aria-expanded="true"
class="defaultCollapseButton"
id="accordion-toggle-button-integrationInfo"
type="button"
<h3
class="headline size-medium margin-none font-weight-bold block"
data-test-headline="true"
>
<span
class="headerInner"
<button
aria-controls="accordion1"
aria-expanded="true"
class="defaultCollapseButton"
id="accordion-toggle-button-integrationInfo"
type="button"
>
<span
class="defaultHeaderIcon"
class="headerInner"
>
<span>
Icon
<span
class="defaultHeaderIcon"
>
<span>
Icon
</span>
</span>
<div
class="labelArea"
>
ui-organizations.integration.info
</div>
</span>
<div
class="labelArea"
>
ui-organizations.integration.info
</div>
</span>
</button>
</h3>
</button>
</h3>
</div>
</div>
</div>
<div
Expand Down Expand Up @@ -291,41 +295,45 @@ exports[`OrganizationIntegrationForm should render correct form structure 1`] =
id="edi"
>
<div
class="headerWrapper"
style="width: 100%; display: flex;"
tabindex="-1"
>
<div
class="header default"
class="headerWrapper"
>
<h3
class="headline size-medium margin-none font-weight-bold block"
data-test-headline="true"
<div
class="header default"
>
<button
aria-controls="accordion2"
aria-expanded="true"
class="defaultCollapseButton"
id="accordion-toggle-button-edi"
type="button"
<h3
class="headline size-medium margin-none font-weight-bold block"
data-test-headline="true"
>
<span
class="headerInner"
<button
aria-controls="accordion2"
aria-expanded="true"
class="defaultCollapseButton"
id="accordion-toggle-button-edi"
type="button"
>
<span
class="defaultHeaderIcon"
class="headerInner"
>
<span>
Icon
<span
class="defaultHeaderIcon"
>
<span>
Icon
</span>
</span>
<div
class="labelArea"
>
ui-organizations.integration.edi
</div>
</span>
<div
class="labelArea"
>
ui-organizations.integration.edi
</div>
</span>
</button>
</h3>
</button>
</h3>
</div>
</div>
</div>
<div
Expand Down Expand Up @@ -865,41 +873,45 @@ exports[`OrganizationIntegrationForm should render correct form structure 1`] =
id="ftp"
>
<div
class="headerWrapper"
style="width: 100%; display: flex;"
tabindex="-1"
>
<div
class="header default"
class="headerWrapper"
>
<h3
class="headline size-medium margin-none font-weight-bold block"
data-test-headline="true"
<div
class="header default"
>
<button
aria-controls="accordion3"
aria-expanded="true"
class="defaultCollapseButton"
id="accordion-toggle-button-ftp"
type="button"
<h3
class="headline size-medium margin-none font-weight-bold block"
data-test-headline="true"
>
<span
class="headerInner"
<button
aria-controls="accordion3"
aria-expanded="true"
class="defaultCollapseButton"
id="accordion-toggle-button-ftp"
type="button"
>
<span
class="defaultHeaderIcon"
class="headerInner"
>
<span>
Icon
<span
class="defaultHeaderIcon"
>
<span>
Icon
</span>
</span>
<div
class="labelArea"
>
ui-organizations.integration.ftp
</div>
</span>
<div
class="labelArea"
>
ui-organizations.integration.ftp
</div>
</span>
</button>
</h3>
</button>
</h3>
</div>
</div>
</div>
<div
Expand Down Expand Up @@ -1340,41 +1352,45 @@ exports[`OrganizationIntegrationForm should render correct form structure 1`] =
id="scheduling"
>
<div
class="headerWrapper"
style="width: 100%; display: flex;"
tabindex="-1"
>
<div
class="header default"
class="headerWrapper"
>
<h3
class="headline size-medium margin-none font-weight-bold block"
data-test-headline="true"
<div
class="header default"
>
<button
aria-controls="accordion4"
aria-expanded="true"
class="defaultCollapseButton"
id="accordion-toggle-button-scheduling"
type="button"
<h3
class="headline size-medium margin-none font-weight-bold block"
data-test-headline="true"
>
<span
class="headerInner"
<button
aria-controls="accordion4"
aria-expanded="true"
class="defaultCollapseButton"
id="accordion-toggle-button-scheduling"
type="button"
>
<span
class="defaultHeaderIcon"
class="headerInner"
>
<span>
Icon
<span
class="defaultHeaderIcon"
>
<span>
Icon
</span>
</span>
<div
class="labelArea"
>
ui-organizations.integration.scheduling
</div>
</span>
<div
class="labelArea"
>
ui-organizations.integration.scheduling
</div>
</span>
</button>
</h3>
</button>
</h3>
</div>
</div>
</div>
<div
Expand Down Expand Up @@ -1494,6 +1510,5 @@ exports[`OrganizationIntegrationForm should render correct form structure 1`] =
</div>
</section>
</div>
<div />
</DocumentFragment>
`;
Loading

0 comments on commit d2fe45f

Please sign in to comment.