Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERM-1958: Write registry entry for Organization lookup #477

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

peterboehm
Copy link

Purpose

Approach

TODOS and Open Questions

Learning

Pre-Merge Checklist

Before merging this PR, please go through the following list and take appropriate actions.

  • I've added appropriate record to the CHANGELOG.md
  • Does this PR meet or exceed the expected quality standards?
    • Code coverage on new code is 80% or greater
    • Duplications on new code is 3% or less
    • There are no major code smells or security issues
  • Does this introduce breaking changes?
    • If any API-related changes - okapi interfaces and permissions are reviewed/changed correspondingly
    • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

  • What other modules will these changes impact?
  • Do JIRAs exist to update the impacted modules?
    • If not, please create them
    • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
    • Do they have all they appropriate links to blocked/related issues?
  • Are the JIRAs under active development?
    • If not, contact the project's PO and make sure they're aware of the urgency.
  • Do PRs exist for these changes?
    • If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

@peterboehm peterboehm changed the title Erm 1958 ERM-1958: Write registry entry for Organization lookup Mar 21, 2022
Fixes to registry code, allow for a renderOrganiztions prop to customise card output
@id-jenkins
Copy link

yarn run v1.22.17
$ eslint .

/home/jenkins/workspace/olio-org_ui-organizations_PR-477/project/OrganizationLookup.js
37:3 error 'renderOrganizations' is missing in props validation react/prop-types
38:11 error Missing trailing comma comma-dangle

/home/jenkins/workspace/olio-org_ui-organizations_PR-477/project/src/Organizations/OrganizationsList/OrganizationsListFilter/OrganizationsListFilter.js
30:31 warning React Hook useCallback received a function whose dependencies are unknown. Pass an inline function instead react-hooks/exhaustive-deps

/home/jenkins/workspace/olio-org_ui-organizations_PR-477/project/src/Organizations/OrganizationsList/hooks/useBuildQuery/useBuildQuery.js
16:10 warning React Hook useCallback received a function whose dependencies are unknown. Pass an inline function instead react-hooks/exhaustive-deps

/home/jenkins/workspace/olio-org_ui-organizations_PR-477/project/src/interfaces/EditInterface/EditInterfaceContainer.js
29:6 warning React Hook useEffect has missing dependencies: 'isNew' and 'mutator.interfaceCredentials'. Either include them or remove the dependency array react-hooks/exhaustive-deps

✖ 5 problems (2 errors, 3 warnings)
1 error and 0 warnings potentially fixable with the --fix option.

info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

1 similar comment
@id-jenkins
Copy link

yarn run v1.22.17
$ eslint .

/home/jenkins/workspace/olio-org_ui-organizations_PR-477/project/OrganizationLookup.js
37:3 error 'renderOrganizations' is missing in props validation react/prop-types
38:11 error Missing trailing comma comma-dangle

/home/jenkins/workspace/olio-org_ui-organizations_PR-477/project/src/Organizations/OrganizationsList/OrganizationsListFilter/OrganizationsListFilter.js
30:31 warning React Hook useCallback received a function whose dependencies are unknown. Pass an inline function instead react-hooks/exhaustive-deps

/home/jenkins/workspace/olio-org_ui-organizations_PR-477/project/src/Organizations/OrganizationsList/hooks/useBuildQuery/useBuildQuery.js
16:10 warning React Hook useCallback received a function whose dependencies are unknown. Pass an inline function instead react-hooks/exhaustive-deps

/home/jenkins/workspace/olio-org_ui-organizations_PR-477/project/src/interfaces/EditInterface/EditInterfaceContainer.js
29:6 warning React Hook useEffect has missing dependencies: 'isNew' and 'mutator.interfaceCredentials'. Either include them or remove the dependency array react-hooks/exhaustive-deps

✖ 5 problems (2 errors, 3 warnings)
1 error and 0 warnings potentially fixable with the --fix option.

info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@id-jenkins
Copy link

yarn run v1.22.18
$ eslint .

/home/jenkins/workspace/olio-org_ui-organizations_PR-477/project/OrganizationLookup.js
37:3 error 'renderOrganizations' is missing in props validation react/prop-types
38:11 error Missing trailing comma comma-dangle

/home/jenkins/workspace/olio-org_ui-organizations_PR-477/project/src/Organizations/OrganizationsList/OrganizationsListFilter/OrganizationsListFilter.js
31:31 warning React Hook useCallback received a function whose dependencies are unknown. Pass an inline function instead react-hooks/exhaustive-deps

/home/jenkins/workspace/olio-org_ui-organizations_PR-477/project/src/Organizations/OrganizationsList/hooks/useBuildQuery/useBuildQuery.js
16:10 warning React Hook useCallback received a function whose dependencies are unknown. Pass an inline function instead react-hooks/exhaustive-deps

/home/jenkins/workspace/olio-org_ui-organizations_PR-477/project/src/interfaces/EditInterface/EditInterfaceContainer.js
29:6 warning React Hook useEffect has missing dependencies: 'isNew' and 'mutator.interfaceCredentials'. Either include them or remove the dependency array react-hooks/exhaustive-deps

✖ 5 problems (2 errors, 3 warnings)
1 error and 0 warnings potentially fixable with the --fix option.

info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants