UIORGS-336: Creating or changing a vendor code using number generator in Organizations App #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hooked up Number generator to Organizations
Added servint as an optionalOkapiInterface dependency, and protected code against being called when interface is not present
…eat/number_generator
Small tweaks, brought number generator code in line with users PR refs UIORGS-336, UIORGS-337
Update generator code to use the new codes defined in this PR: folio-org/mod-service-interaction#72
Added new permission and blocked access to number generator page based on that permission
…eat/number_generator
…eat/number_generator
Update to use servint 3
…eat/number_generator
Use new service-interaction
…eat/number_generator
…eat/number_generator
Swapped implementation to full Modal implementation as per the other apps
…eat/number_generator
Changed Button from fullWidth to scale with text
…eat/number_generator
…eat/number_generator
…eat/number_generator
…eat/number_generator
…izations into feat/number_generator
Change back to do what is done on master
…eat/number_generator
Mocked useSettings to rectify failing test
|
Hello. I have updated the implementation provided by @EthanFreestone and made the requested changes:
I have also updated the PR description and included a screencast for better clarity on the changes. |
alb3rtino
force-pushed
the
feat/number_generator
branch
2 times, most recently
from
ebd1c65 to
1454363
Compare
|
Hi @NikitaSedyx,
|
# Conflicts: # CHANGELOG.md # src/common/hooks/index.js
SerhiiNosko
reviewed
Dec 5, 2024
NikitaSedyx
reviewed
Dec 5, 2024
src/common/hooks/useVendorCodeGeneratorSettings/useVendorCodeGeneratorSettings.js
Outdated
Show resolved
Hide resolved
|
@alb3rtino overall UI is very close to the final stage, only settings storage should be changed |
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md
SerhiiNosko
approved these changes
Dec 9, 2024
NikitaSedyx
approved these changes
Dec 11, 2024
usavkov-epam
approved these changes
Dec 11, 2024
src/common/hooks/useVendorCodeGeneratorSettings/useVendorCodeGeneratorSettings.js
Outdated
Show resolved
Hide resolved
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://folio-org.atlassian.net/browse/UIORGS-336
https://folio-org.atlassian.net/browse/UIORGS-337
Requires the
organizations-storage.settings 1.1interface, which constitutes a breaking change.Refs UXPROD-3891, UIORGS-336, UIORGS-337
screencast.webm