-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UIORGS-390 Implement organization's banking information form #580
Conversation
Jest Unit Test Statistics 1 files ± 0 81 suites +12 3m 46s ⏱️ + 1m 8s Results for commit 31f09ca. ± Comparison against base commit 485f859. This pull request removes 2 and adds 27 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
…Settings: to not confuse domens
8d4149a
to
3716f59
Compare
Kudos, SonarCloud Quality Gate passed! |
...rganizationBankingInfoForm/BankingInformationFieldArray/BankingInformationFieldArray.test.js
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Purpose
https://issues.folio.org/browse/UIORGS-390
Certain libraries need to store organization-specific banking and account information in the organization record, independent of the normal account information stored in an organization record.
Approach
Screenshot
chrome_Oo3kvCIgW6.mp4
Pre-Merge Checklist
Before merging this PR, please go through the following list and take appropriate actions.
If there are breaking changes, please STOP and consider the following:
Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.
While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.