UIORGS-417: Add validation for Day field in Monthly scheduler for export method
#600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The code is dependent on this PR folio-org/stripes-acq-components#748 |
|
BogdanDenis
approved these changes
Jan 16, 2024
usavkov-epam
approved these changes
Jan 16, 2024
NikitaSedyx
pushed a commit
that referenced
this pull request
Jan 23, 2024
… export method (#600) * UIORGS-417: Add validation for `Day` field in `Monthly` scheduler for export method * test: add test coverage for util functions * refactor validation code * test: improve test coverage
NikitaSedyx
pushed a commit
that referenced
this pull request
Jan 23, 2024
… export method (#600) * UIORGS-417: Add validation for `Day` field in `Monthly` scheduler for export method * test: add test coverage for util functions * refactor validation code * test: improve test coverage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
UIORGS-417- Add validation for
Dayfield inMonthlyscheduler for export methodCorresponding PR. folio-org/stripes-acq-components#748
Approach
Screen.Recording.2024-01-15.at.18.54.08.mov
TODOS and Open Questions
Learning
Pre-Merge Checklist
Before merging this PR, please go through the following list and take appropriate actions.
If there are breaking changes, please STOP and consider the following:
Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.
While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.