Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIORGS-436 Settings > Organizations > Banking information is not properly fenced off by permissions #628

Merged
merged 2 commits into from
Jul 1, 2024

Conversation

NikitaSedyx
Copy link
Contributor

Purpose

Approach

TODOS and Open Questions

Learning

Pre-Merge Checklist

Before merging this PR, please go through the following list and take appropriate actions.

  • I've added appropriate record to the CHANGELOG.md
  • Does this PR meet or exceed the expected quality standards?
    • Code coverage on new code is 80% or greater
    • Duplications on new code is 3% or less
    • There are no major code smells or security issues
  • Does this introduce breaking changes?
    • If any API-related changes - okapi interfaces and permissions are reviewed/changed correspondingly
    • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

  • What other modules will these changes impact?
  • Do JIRAs exist to update the impacted modules?
    • If not, please create them
    • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
    • Do they have all they appropriate links to blocked/related issues?
  • Are the JIRAs under active development?
    • If not, contact the project's PO and make sure they're aware of the urgency.
  • Do PRs exist for these changes?
    • If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

Copy link

github-actions bot commented Jul 1, 2024

Jest Unit Test Statistics

    1 files  ±0    84 suites  ±0   3m 16s ⏱️ +18s
272 tests ±0  272 ✔️ +1  0 💤 ±0  0  - 1 
276 runs  ±0  276 ✔️ +1  0 💤 ±0  0  - 1 

Results for commit c553193. ± Comparison against base commit 8d3f8d9.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jul 1, 2024

BigTest Unit Test Statistics

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ±0 

Results for commit c553193. ± Comparison against base commit 8d3f8d9.

♻️ This comment has been updated with latest results.

Copy link

sonarqubecloud bot commented Jul 1, 2024

@NikitaSedyx NikitaSedyx merged commit 19daf93 into master Jul 1, 2024
6 checks passed
@NikitaSedyx NikitaSedyx deleted the UIORGS-436 branch July 1, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants