-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UIORGS-356 - Show in version history record view, which fields have been edited #658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
usavkov-epam
force-pushed
the
UIORGS-356
branch
from
November 25, 2024 16:55
51541a8
to
40a886b
Compare
...ntactInfoVersionView/components/ContactCardHeaderVersionView/ContactCardHeaderVersionView.js
Outdated
Show resolved
Hide resolved
...n/components/OrganizationContactInfoVersionView/components/ContactPersonPhonesVersionView.js
Outdated
Show resolved
Hide resolved
...sion/components/OrganizationContactPeopleVersionView/OrganizationContactPeopleVersionView.js
Show resolved
Hide resolved
...s/OrganizationVersion/hooks/useSelectedOrganizationVersion/useSelectedOrganizationVersion.js
Outdated
Show resolved
Hide resolved
alisher-epam
approved these changes
Nov 26, 2024
SerhiiNosko
approved these changes
Nov 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great and huge work done here
Quality Gate passedIssues Measures |
11 tasks
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
https://folio-org.atlassian.net/browse/UIORGS-356
Give the user the ability to access the change log that displays all edits that have been made to the record.
Approach
Apply ACQ approach to display version history (
ui-orders
app is a prototype).Prepare organization components views adapted for version history context. Implement a hook, that will aggregate version history data for specific versions.
Screenshot
chrome_xqm4fomDmQ.mp4
Pre-Merge Checklist
Before merging this PR, please go through the following list and take appropriate actions.
If there are breaking changes, please STOP and consider the following:
Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.
While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.