Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIORGS-356 - Show in version history record view, which fields have been edited #658

Merged
merged 9 commits into from
Nov 27, 2024

Conversation

usavkov-epam
Copy link
Contributor

@usavkov-epam usavkov-epam commented Nov 25, 2024

Purpose

https://folio-org.atlassian.net/browse/UIORGS-356

Give the user the ability to access the change log that displays all edits that have been made to the record.

Approach

Apply ACQ approach to display version history (ui-orders app is a prototype).

Prepare organization components views adapted for version history context. Implement a hook, that will aggregate version history data for specific versions.

Screenshot

chrome_xqm4fomDmQ.mp4

Pre-Merge Checklist

Before merging this PR, please go through the following list and take appropriate actions.

  • I've added appropriate record to the CHANGELOG.md
  • Does this PR meet or exceed the expected quality standards?
    • Code coverage on new code is 80% or greater
    • Duplications on new code is 3% or less
    • There are no major code smells or security issues
  • Does this introduce breaking changes?
    • If any API-related changes - okapi interfaces and permissions are reviewed/changed correspondingly
    • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

  • What other modules will these changes impact?
  • Do JIRAs exist to update the impacted modules?
    • If not, please create them
    • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
    • Do they have all they appropriate links to blocked/related issues?
  • Are the JIRAs under active development?
    • If not, contact the project's PO and make sure they're aware of the urgency.
  • Do PRs exist for these changes?
    • If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

@usavkov-epam usavkov-epam self-assigned this Nov 25, 2024
Copy link

github-actions bot commented Nov 25, 2024

Jest Unit Test Statistics

    1 files  ±0    89 suites  +3   2m 54s ⏱️ +9s
280 tests +4  278 ✔️ +5  2 💤 ±0  0  - 1 
284 runs  +4  281 ✔️ +5  3 💤 ±0  0  - 1 

Results for commit c1569f8. ± Comparison against base commit 9a29cc4.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 25, 2024

BigTest Unit Test Statistics

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ±0 

Results for commit c1569f8. ± Comparison against base commit 9a29cc4.

♻️ This comment has been updated with latest results.

@usavkov-epam usavkov-epam requested a review from a team November 26, 2024 14:21
Copy link

@SerhiiNosko SerhiiNosko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great and huge work done here

@usavkov-epam usavkov-epam merged commit 1b58202 into master Nov 27, 2024
6 checks passed
@usavkov-epam usavkov-epam deleted the UIORGS-356 branch November 27, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants