UIPFIMP-52: React-highlighter is incompatible with react 17 #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed! |
zburke
approved these changes
Nov 7, 2022
There was a problem hiding this comment.
True confession: I'm having a hard time understanding how highlighting works now, except that it seems to have been outsourced to either DI or stripes-acq-components. That's fine, but note that if you want to share components from DI, DI really should formally export them. Exporting Importing by private path is dangerous because that path could change at any time without a semver change because, from DI's point of view, that path is just a private implementation detail.
11 tasks
mariia-aloshyna
approved these changes
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link
UIPFIMP-52
Approach
FindImportProfilecomponentlistTemplatecomponent fromAbstractContainertoFindImportProfileListTemplatecomponent from ui-data-import to stripes-data-transfer-componentsVideo
UIPFIMP-52.mp4