-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UIPFU-76 Revert - ECS - 'Do not display shadow users in search results' #244
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also remove CHANGELOG entry
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the entry in changelog.md and also write a summary in the PR description and also on the associated ticket as to why the changes are being reverted. This will be helpful for future visitors of the PR and ticket.
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Purpose
https://issues.folio.org/browse/UIPFU-76
As far as the "User type" filter was implemented for the user search and currently includes "shadow" users in the results, the plugin's changes were reverted to keep consistency in the query (This ticket originally was created for consistency purposes).
Approach
Revert #241
Screenshots
chrome_eC9MilST7o.mp4
Pre-Merge Checklist
Before merging this PR, please go through the following list and take appropriate actions.
If there are breaking changes, please STOP and consider the following:
Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.
While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.