Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIPFU-100 Add modal title prop support #280

Merged
merged 3 commits into from
Oct 25, 2024
Merged

UIPFU-100 Add modal title prop support #280

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
56f8235
UIPFU-100 Add modal title prop support
NikitaSedyx Oct 24, 2024
b6616d9
Update CHANGELOG.md
NikitaSedyx Oct 24, 2024
51588d2
Update UserSearchModal.js
NikitaSedyx Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
* Add Jest unit tests for ui-plugin-find-user/src/Filters.js. Refs UIPFU-81.
* Fix pagination issues with `Unassigned` filter. Refs UIPFU-96.
* Add Jest unit tests for ui-plugin-find-user/src/PluginFindUser.js. Refs UIPFU-82.
* Add modal title prop support. Refs UIPFU-100.

## [7.1.2](https://github.com/folio-org/ui-plugin-find-user/tree/v7.1.2) (2024-09-05)
[Full Changelog](https://github.com/folio-org/ui-plugin-find-user/compare/v7.1.1...v7.1.2)
Expand Down
3 changes: 2 additions & 1 deletion src/UserSearchModal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
dataKey: PropTypes.string,
contentRef: PropTypes.object,
modalRef: PropTypes.object,
modalTitle: PropTypes.node,
restoreFocus: PropTypes.bool,
initialSelectedUsers: PropTypes.shape({
[PropTypes.string]: PropTypes.shape({
Expand Down Expand Up @@ -98,7 +99,7 @@
contentClass={css.modalContent}
dismissible
enforceFocus={false}
label={<FormattedMessage id="ui-plugin-find-user.modal.label" />}
label={modalTitle || <FormattedMessage id="ui-plugin-find-user.modal.label" />}

Check failure on line 102 in src/UserSearchModal.js

View workflow job for this annotation

GitHub Actions / github-actions-ci 

'modalTitle' is not defined

Check failure on line 102 in src/UserSearchModal.js

View workflow job for this annotation

GitHub Actions / github-actions-ci 

'modalTitle' is not defined
NikitaSedyx marked this conversation as resolved.
Show resolved Hide resolved
open={openWhen}
ref={this.modalRef}
size="large"
Expand Down
Loading