UIREQ-996: Update Jest/RTL tests #1107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dmitriy-Litvinenko
force-pushed
the
UIREQ-996
branch
from
cfb0e4e to
40f139a
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
artem-blazhko
approved these changes
Oct 12, 2023
Dmitriy-Litvinenko
force-pushed
the
UIREQ-996
branch
from
40f139a to
70974fc
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Terala-Priyanka
approved these changes
Nov 17, 2023
There was a problem hiding this comment.
Hey @Dmitriy-Litvinenko
If you wish that, going forward such React imports do not happen in test files (or have lint complain such unwanted imports), you can adjust or modify lint rule https://github.com/folio-org/eslint-config-stripes/blob/0754e5740231869bb611146563ccce6c96ee4c0b/index.js#L79 in .eslintrc file in this repository.
example -
"overrides": [
{
"files": [ "src/**/tests/*", "test/**/*" ],
"rules": {
"no-unused-vars": ["warn", {
"argsIgnorePattern": "^_"
}]
}
}
],
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Update Jest/RTL tests
Approach
Refs
https://issues.folio.org/browse/UIREQ-996