UIREQ-1040 - Hide Actions menu on closed request of DCB Transaction #1121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BogdanDenis
requested changes
Nov 15, 2023
src/ViewRequest.test.js
Outdated
| ...openValidRequest, | ||
| }, | ||
| ], | ||
| render( |
There was a problem hiding this comment.
This render is repeated multiple times - let's move it to a function renderViewRequest and call it instead
There was a problem hiding this comment.
Hey @BogdanDenis
Implemented not only your recommendations and but also more refinement. Please re-review.
BogdanDenis
approved these changes
Nov 15, 2023
gurleenkaurbp
approved these changes
Nov 15, 2023
mariia-aloshyna
approved these changes
Nov 16, 2023
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
UIREQ-1040 - [DCB] Request details: Hide Actions menu on closed request
Approach
Hide action menu when it is a DCB transaction - which means the request is involved with either virtual user or virtual item.
Refs
Screenshots
Action menu hidden for "Closed-Filled" Request on Borrowing Library
Action menu hidden for "Closed-Filled" Request on Lending Library
Action menu hidden for "Closed-cancelled" Request on Lending Library
Pre-Merge Checklist
Before merging this PR, please go through the following list and take appropriate actions.
If there are breaking changes, please STOP and consider the following:
Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.
While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.