-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UIREQ-1171: Feature toggle #1224
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Requests app.: Moving request (ECS with mod-tlr enabled). Refs UIREQ-1100.
UIREQ-1105: Hide Action menu on secondary requests (ECS + mod-tlr)
artem-blazhko
force-pushed
the
UIREQ-1171
branch
from
November 12, 2024 19:29
22ca2d0
to
6039912
Compare
artem-blazhko
force-pushed
the
UIREQ-1171
branch
from
November 13, 2024 17:30
a1c4708
to
c581bc7
Compare
…into UIREQ-1171
artem-blazhko
force-pushed
the
UIREQ-1171
branch
from
November 13, 2024 17:36
c581bc7
to
17ee98e
Compare
artem-blazhko
requested review from
Dmitriy-Litvinenko and
IvanKryzhanovskyi
November 13, 2024 19:35
Dmitriy-Litvinenko
approved these changes
Nov 15, 2024
IvanKryzhanovskyi
approved these changes
Nov 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Quality Gate failedFailed conditions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Use feature flag
enableEcsRequests
from stripes configuration file for handling functionality for ECS and not ECS related envs.Approach
It was decided that we should use separated components with old and new implementation instead of having a lot of
if...else
statements in the code.This approach let us split functionality by feature flags much faster.
Refs
UIREQ-1171
Notes