Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIREQ-1171: Feature toggle #1224

Merged
merged 38 commits into from
Nov 18, 2024
Merged

UIREQ-1171: Feature toggle #1224

merged 38 commits into from
Nov 18, 2024

Conversation

artem-blazhko
Copy link
Contributor

@artem-blazhko artem-blazhko commented Nov 12, 2024

Purpose

Use feature flag enableEcsRequests from stripes configuration file for handling functionality for ECS and not ECS related envs.

Approach

It was decided that we should use separated components with old and new implementation instead of having a lot of if...else statements in the code.
This approach let us split functionality by feature flags much faster.

Refs

UIREQ-1171

Notes

  • It is a temporary solution that was discussed within the team and approved by solution architect. In the next release that temporary functionality will be fully removed and we will not use any feature flag.

artem-blazhko and others added 27 commits February 19, 2024 12:18
Requests app.: Moving request (ECS with mod-tlr enabled). Refs UIREQ-1100.
UIREQ-1105: Hide Action menu on secondary requests (ECS + mod-tlr)
Copy link

github-actions bot commented Nov 12, 2024

Jest Unit Test Statistics

       1 files  ±    0       62 suites  +10   1m 37s ⏱️ +18s
   794 tests +    8     794 ✔️ +    8  0 💤 ±0  0 ±0 
1 103 runs  +316  1 103 ✔️ +316  0 💤 ±0  0 ±0 

Results for commit 893ae8e. ± Comparison against base commit 310cd5e.

♻️ This comment has been updated with latest results.

@artem-blazhko artem-blazhko changed the title UIREQ-1171: UIREQ-1171: Feature toggle Nov 12, 2024
@artem-blazhko artem-blazhko marked this pull request as ready for review November 13, 2024 19:34
Copy link
Contributor

@IvanKryzhanovskyi IvanKryzhanovskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@artem-blazhko artem-blazhko changed the base branch from UXPROD-4559-ECS to master November 18, 2024 12:25
@artem-blazhko artem-blazhko changed the base branch from master to UXPROD-4559-ECS November 18, 2024 12:26
@artem-blazhko artem-blazhko changed the base branch from UXPROD-4559-ECS to master November 18, 2024 12:26
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
80.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@artem-blazhko artem-blazhko merged commit e1d9180 into master Nov 18, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants