-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UIREQ-1187 - Update permission checks of ui-users #1228
Conversation
Hello @Terala-Priyanka , @artem-blazhko How i understand we have the same open questions that we have in folio-org/ui-checkout#881 (folio-org/ui-checkout#881 (comment) and folio-org/ui-checkout#881 (comment)) |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes LGTM but you must update package.json
's peerdep on stripes to ^9.2.5
and devdep on stripes-core to ^10.2.3
to use <IfAny>
.
Quality Gate passedIssues Measures |
Purpose
UIREQ-1187 - Update permission checks of ui-users
Approach
Several permissions of module ui-users have been updated in the scope of UIU-3214
ui-requests module leverages various ui-users permissions in order to conditionally render several buttons, menu items…
Below is the list, where some refactor is needed for the permission checks-
ui-requests/src/PatronBlockModal.js at 70ed9a5c0d97eefd39dfac01c8be0454e6ae32c4 · folio-org/ui-requests
Leverage “hasAnyPerm” and “IfAnyPermission” utilities from stripes-core in order to pick either the old permission name or updated/new permission name.
The above two utilities have been recently introduced in the scope of STCOR-910
Refs
Screenshots
Pre-Merge Checklist
Before merging this PR, please go through the following list and take appropriate actions.
If there are breaking changes, please STOP and consider the following:
Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.
While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.