Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIREQ-1187 - Update permission checks of ui-users #1228

Merged
merged 5 commits into from
Nov 19, 2024
Merged

Conversation

Terala-Priyanka
Copy link
Contributor

@Terala-Priyanka Terala-Priyanka commented Nov 15, 2024

Purpose

UIREQ-1187 - Update permission checks of ui-users

Approach

Several permissions of module ui-users have been updated in the scope of UIU-3214
ui-requests module leverages various ui-users permissions in order to conditionally render several buttons, menu items…
Below is the list, where some refactor is needed for the permission checks-

ui-requests/src/PatronBlockModal.js at 70ed9a5c0d97eefd39dfac01c8be0454e6ae32c4 · folio-org/ui-requests

Leverage “hasAnyPerm” and “IfAnyPermission” utilities from stripes-core in order to pick either the old permission name or updated/new permission name.
The above two utilities have been recently introduced in the scope of STCOR-910

Refs

Screenshots

Pre-Merge Checklist

Before merging this PR, please go through the following list and take appropriate actions.

  • I've added appropriate record to the CHANGELOG.md
  • Does this PR meet or exceed the expected quality standards?
    • Code coverage on new code is 80% or greater
    • Duplications on new code is 3% or less
    • There are no major code smells or security issues
  • Does this introduce breaking changes?
    • If any API-related changes - okapi interfaces and permissions are reviewed/changed correspondingly
    • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

  • What other modules will these changes impact?
  • Do JIRAs exist to update the impacted modules?
    • If not, please create them
    • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
    • Do they have all they appropriate links to blocked/related issues?
  • Are the JIRAs under active development?
    • If not, contact the project's PO and make sure they're aware of the urgency.
  • Do PRs exist for these changes?
    • If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

Copy link

github-actions bot commented Nov 15, 2024

Jest Unit Test Statistics

       1 files  ±0       62 suites  ±0   1m 37s ⏱️ -5s
   794 tests ±0     794 ✔️ ±0  0 💤 ±0  0 ±0 
1 103 runs  ±0  1 103 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit ee7a265. ± Comparison against base commit e1d9180.

♻️ This comment has been updated with latest results.

@Terala-Priyanka Terala-Priyanka requested review from a team, zburke and artem-blazhko November 15, 2024 12:27
@Dmitriy-Litvinenko
Copy link
Contributor

Hello @Terala-Priyanka , @artem-blazhko How i understand we have the same open questions that we have in folio-org/ui-checkout#881 (folio-org/ui-checkout#881 (comment) and folio-org/ui-checkout#881 (comment))
Let's wait until we will get answer on them.

@Dmitriy-Litvinenko
Copy link
Contributor

Hello @Terala-Priyanka , @artem-blazhko How i understand we have the same open questions that we have in folio-org/ui-checkout#881 (folio-org/ui-checkout#881 (comment) and folio-org/ui-checkout#881 (comment)) Let's wait until we will get answer on them.

folio-org/ui-checkout#881 (comment)

Copy link
Member

@zburke zburke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM but you must update package.json's peerdep on stripes to ^9.2.5 and devdep on stripes-core to ^10.2.3 to use <IfAny>.

@Terala-Priyanka Terala-Priyanka merged commit eef6ca8 into master Nov 19, 2024
5 checks passed
@Terala-Priyanka Terala-Priyanka deleted the UIREQ-1187 branch November 19, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants