Add hasLoaded prop

folio-org · Dec 2, 2024 · b968361 · b968361
1 parent 431c4a9
commit b968361
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/src/views/LoanDetails/LoanProxyDetails.js b/src/views/LoanDetails/LoanProxyDetails.js
@@ -22,6 +22,7 @@ class LoanProxyDetails extends React.Component {
     resources: PropTypes.shape({
       proxy: PropTypes.shape({
         records: PropTypes.arrayOf(PropTypes.object),
+        hasLoaded: PropTypes.bool,
       }),
     }),
     mutator: PropTypes.shape({
@@ -45,7 +46,6 @@ class LoanProxyDetails extends React.Component {
 
   getUserFullName() {
     const proxy = (this.props.resources.proxy || {}).records || [];
-    console.log('proxy.length: ', proxy.length);
     if (proxy.length === 1 && proxy[0].id === this.props.id) {
       return <Link to={`/users/view/${this.props.id}`}>{getFullName(proxy[0])}</Link>;
     }

diff --git a/src/views/LoanDetails/LoanProxyDetails.test.js b/src/views/LoanDetails/LoanProxyDetails.test.js
@@ -21,7 +21,8 @@ const props = (propID, proxyID) => {
     id: propID,
     resources: {
       proxy: {
-        records: [{ id: proxyID }]
+        records: [{ id: proxyID }],
+        hasLoaded: true,
       }
     },
     mutator: {
@@ -57,11 +58,15 @@ describe('Render LoanProxyDetails component', () => {
     const newprops = {
       id: 'test',
       resources: {
-        proxy: null
+        proxy: {
+          records: null,
+          hasLoaded: true,
+        },
       },
       mutator: {
         proxy: {
           GET: jest.fn().mockRejectedValueOnce(),
+          reset: jest.fn(),
         },
       },
       showErrorCallout: showErrorMock,