Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v11.0.9 #2824

Merged
merged 4 commits into from
Dec 16, 2024
Merged

Release v11.0.9 #2824

merged 4 commits into from
Dec 16, 2024

Conversation

Terala-Priyanka
Copy link
Contributor

@Terala-Priyanka Terala-Priyanka commented Dec 13, 2024

Purpose

Release v11.0.9

Approach

TODOS and Open Questions

Learning

Pre-Merge Checklist

Before merging this PR, please go through the following list and take appropriate actions.

  • I've added appropriate record to the CHANGELOG.md
  • Does this PR meet or exceed the expected quality standards?
    • Code coverage on new code is 80% or greater
    • Duplications on new code is 3% or less
    • There are no major code smells or security issues
  • Does this introduce breaking changes?
    • If any API-related changes - okapi interfaces and permissions are reviewed/changed correspondingly
    • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

  • What other modules will these changes impact?
  • Do JIRAs exist to update the impacted modules?
    • If not, please create them
    • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
    • Do they have all they appropriate links to blocked/related issues?
  • Are the JIRAs under active development?
    • If not, contact the project's PO and make sure they're aware of the urgency.
  • Do PRs exist for these changes?
    • If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

@Terala-Priyanka Terala-Priyanka marked this pull request as draft December 13, 2024 12:01
Copy link

sonarcloud bot commented Dec 13, 2024

@Terala-Priyanka Terala-Priyanka marked this pull request as ready for review December 13, 2024 12:14
@Terala-Priyanka Terala-Priyanka requested a review from a team December 13, 2024 12:14
@Terala-Priyanka Terala-Priyanka changed the title UIU-3282: add capability to access users-keycloak delete method (#2810) Release v11.0.9 Dec 13, 2024
Copy link
Member

@zburke zburke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

A strategy I like for picking commits from master onto release branches is cherry-pick -x. -x appends a reference to the original commit at the bottom of the commit message (example). That allows GitHub to link back to the original commit, PR, and author, which is very helpful in the scope of troubleshooting. I have cherry-pick -x in my ~/.gitconfig aliased to px so it's easier to type.

To be clear: the process you have for publishing patch releases is 100% fine. I'm merely sharing an alternative approach that includes more history on the release branch.

@Terala-Priyanka
Copy link
Contributor Author

LGTM

A strategy I like for picking commits from master onto release branches is cherry-pick -x. -x appends a reference to the original commit at the bottom of the commit message (example). That allows GitHub to link back to the original commit, PR, and author, which is very helpful in the scope of troubleshooting. I have cherry-pick -x in my ~/.gitconfig aliased to px so it's easier to type.

To be clear: the process you have for publishing patch releases is 100% fine. I'm merely sharing an alternative approach that includes more history on the release branch.

Thank you for sharing the alternate approach. I see the benefits and would follow it going forward!

@Terala-Priyanka Terala-Priyanka merged commit d6b2088 into b11.0 Dec 16, 2024
5 checks passed
@Terala-Priyanka Terala-Priyanka deleted the UIU-3299-R-bugfix-release branch December 16, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants