-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v11.0.9 #2824
Release v11.0.9 #2824
Conversation
…ithin withUserRoles HOC used with UserEdit. (#2821) Refs UIU-3294.
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
A strategy I like for picking commits from master onto release branches is cherry-pick -x
. -x appends a reference to the original commit at the bottom of the commit message (example). That allows GitHub to link back to the original commit, PR, and author, which is very helpful in the scope of troubleshooting. I have cherry-pick -x
in my ~/.gitconfig
aliased to px
so it's easier to type.
To be clear: the process you have for publishing patch releases is 100% fine. I'm merely sharing an alternative approach that includes more history on the release branch.
Thank you for sharing the alternate approach. I see the benefits and would follow it going forward! |
Purpose
Release v11.0.9
Approach
TODOS and Open Questions
Learning
Pre-Merge Checklist
Before merging this PR, please go through the following list and take appropriate actions.
If there are breaking changes, please STOP and consider the following:
Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.
While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.