Bugfix for flowing text always adding new page

[rexxmagnus]

Allow text added on a page to flow onto the next page if it already exists, rather than always adding a new page below.

Bugfix
#1201

What kind of change does this PR introduce?

Text added to any page that is followed by another can flow onto the next existing page. This fixes a bug that would always add a new page regardless of whether the page is the last one or not.

Checklist:

• Unit Tests N/A
• Documentation
• Update CHANGELOG.md
• Ready to be merged

Manual tests have been run in the case of using buffered and unbuffered page output.

[rexxmagnus]

Removed redundant !! from code to pass build tests.

[rexxmagnus]

This will require re-testing with the amend of this.document.addPage() to this.document.continueOnNewPage();

[blikblum]

Sorry for the delay.

I'm trying to cut a new release.

Could you add a sample example and a unit test?

@liborm85 @devongovett can you review if this behavior is desired?

[rexxmagnus]

Sorry for the delay.

I'm trying to cut a new release.

Could you add a sample example and a unit test?

@liborm85 @devongovett can you review if this behavior is desired?

Just to clarify, the original issue this is meant to correct was from a use-case where I was producing a two-column layout which was intended to flow onto the next page. See the issue #1201 for a minimal code sample.

[blikblum]

Thanks.

I will wait for other dev opinions on the behavior. BTW: the two column layout example seems not the best one since AFAIK, a complete column implementation is a lot more involved: when a text in the left column overflows should be to continue on right column in the same page. And when the right column overflows should continue on the left column in next page.

A better API would allow to customize what to do when text overflows, add page or not and from what position restarts

Anyway having unit tests and small examples in demo folder improves the likehood of being merged. See recent attachment and form PRs.

[rexxmagnus]

I agree, having an api to control flow would be better. My case is for columns that span pages vertically, rather than the content continuing from left to right in the next column, hence not using the column structure. I don't think my fix should interfere with that default behaviour, although more tests are needed.

[Simolation]

For me, this is also a really important behavior as I am placing form fields (with a text description below that could wrap and trigger the page add) and they should be displayed next to each other. When the page is over they should continue on the next page in the same column. So for me, I don't need the text wrapping behavior to the right you mentioned.

In my opinion, adding a new page at the end when the current page is not the last one is never the desired behavior and is just unexpected. At least I can't imagine a valid use case.

Can I somehow help to speed this merge up?

[blikblum]

Can I somehow help to speed this merge up?

Yes, add a unit test. See current ones to know how can be done

[Simolation]

I just added visual tests and slightly improved the code #1256

[blikblum]

Closed in favor of #1256