Skip to content

Commit

Permalink
Add rationale for production_glyphs_similarity
Browse files Browse the repository at this point in the history
com.google.fonts/check/production_glyphs_similarity
On the Google Fonts Profile.

(PR #4570)
  • Loading branch information
simoncozens authored and felipesanches committed Mar 5, 2024
1 parent a9e386b commit 0b16944
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 0 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ A more detailed list of changes is available in the corresponding milestones for
- **[com.google.fonts/check/metadata/nameid/copyright]:** Added rationale. (PR #4570)
- **[com.google.fonts/check/has_ttfautohint_params]:** Added rationale. (PR #4570)
- **[com.google.fonts/check/smart_dropout]:** Improve rationale with better fixing instructions. (PR #4570)
- **[com.google.fonts/check/production_glyphs_similarity]:** Added rationale. (PR #4570)

#### On the FontValidator profile
- **[com.google.fonts/check/fontvalidator]:** Added rationale. (PR #4570)
Expand Down
6 changes: 6 additions & 0 deletions Lib/fontbakery/checks/googlefonts/hosted.py
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,12 @@ def com_google_fonts_check_version_bump(
id="com.google.fonts/check/production_glyphs_similarity",
conditions=["api_gfonts_ttFont"],
proposal="legacy:check/118",
rationale="""
We check that the glyphs in the font are similar to the glyphs in the
version hosted on fonts.google.com. We do not expect updated fonts to
have exactly the same glyphs as the previous version, but we do expect
the changes to be minimal.
""",
)
def com_google_fonts_check_production_glyphs_similarity(
ttFont, api_gfonts_ttFont, config
Expand Down

0 comments on commit 0b16944

Please sign in to comment.